Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: net/url_request/url_request.h

Issue 118151: Update some comments in url_request.h to clarify that once the request is del... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_host/resource_dispatcher_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request.h
===================================================================
--- net/url_request/url_request.h (revision 17453)
+++ net/url_request/url_request.h (working copy)
@@ -377,7 +377,9 @@
// This method may be called at any time after Start() has been called to
// cancel the request. This method may be called many times, and it has
- // no effect once the response has completed.
+ // no effect once the response has completed. It is guaranteed that no
+ // methods of the delegate will be called after the request has been
+ // cancelled, including during the call to Cancel itself.
void Cancel();
// Cancels the request and sets the error to |os_error| (see net_error_list.h
@@ -396,8 +398,8 @@
// If data is available, Read will return true, and the data and length will
// be returned immediately. If data is not available, Read returns false,
// and an asynchronous Read is initiated. The Read is finished when
- // the caller receives the OnReadComplete callback. OnReadComplete will be
- // always be called, even if there was a failure.
+ // the caller receives the OnReadComplete callback. Unless the request was
+ // cancelled, OnReadComplete will always be called, even if the read failed.
//
// The buf parameter is a buffer to receive the data. If the operation
// completes asynchronously, the implementation will reference the buffer
« no previous file with comments | « chrome/browser/renderer_host/resource_dispatcher_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698