Change PasswordStoreDefault to access the WebDataService from the UI thread o...

Change PasswordStoreDefault to access the WebDataService from the UI thread only.
Enables the PasswordStore refactoring yet again (third time's the charm?).

BUG=12479
TEST=Password save/autofill should continue to work on Windows.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17545

[stuartmorgan, 2009-06-02 22:00:27]

This was backed out again due to continuing to fail reliability
tests--apparently it was luck that my local run passed with the last changes. I
looked deeper this time and discovered that WebDataService's API is not in fact
threadsafe (specifically, I believe the crash was due to the thread_ member of
WDS being destroyed in Shutdown in the middle of a query from PasswordStoreWin),
so this hacks the shim to use PasswordStore as essentially nothing but an
interface, and ignore the background thread. (I considered factoring out an
actual interface class, but since again this isn't something that will survive,
and I don't expect any real implementations to *not* want the threading
behavior, I didn't go that far). While it's a bit ugly in terms of the
subclassing, it makes the threading much simpler.

As before, only the password_store_default and password_store_win classes have
really changed (although password_store.h was altered slightly). I left the
actual password_store_* files checked in during the last backout, so there's a
real diff this time.

(The other platform password_store_* files are only in the CL because I forgot
to mark them as eol:LF in the previous CL.)

[tim (not reviewing), 2009-06-03 21:35:14]

if 17273 was reverted then why is it still the last modified  CL for
password_store.h/cc and password_store_{knome,mac}.h/cc ? A little confused.  If
(heaven forbid, knock on wood) we end up doing this yet again, maybe gcl upload
--issue would help tell the diffs between cl to cl; this is a big patch :)

http://codereview.chromium.org/118131/diff/1/22
File chrome/browser/password_manager/password_store_default.cc (right):

http://codereview.chromium.org/118131/diff/1/22#newcode39
Line 39: PasswordStoreConsumer* consumer) {
nit indent

[stuartmorgan, 2009-06-03 21:45:30]

On 2009/06/03 21:35:14, timsteele wrote:
> if 17273 was reverted then why is it still the last modified  CL for
> password_store.h/cc and password_store_{knome,mac}.h/cc ?

17273 wasn't fully reverted; all of the password_store* files were left in
place, but with the build files and referencing files reverted so that they were
unused.

> If (heaven forbid, knock on wood) we end up doing this yet again, maybe gcl
upload
> --issue would help tell the diffs between cl to cl; this is a big patch :)

Yes, that wold have been a better approach :) Unfortunately I didn't think of
that at the time, so leaving the store files in place was my way of trying to
make this round of review saner.

[tim (not reviewing), 2009-06-03 21:50:39]

LG. Godspeed.