Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5736)

Unified Diff: chrome/browser/password_manager/password_store.h

Issue 118131: Change PasswordStoreDefault to access the WebDataService from the UI thread o... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store.h
===================================================================
--- chrome/browser/password_manager/password_store.h (revision 17405)
+++ chrome/browser/password_manager/password_store.h (working copy)
@@ -35,17 +35,20 @@
// Reimplement this to add custom initialization. Always call this too.
virtual bool Init();
+ // TODO(stuartmorgan): These are only virtual to support the shim version of
+ // password_store_default; once that is fixed, they can become non-virtual.
+
// Adds the given PasswordForm to the secure password store asynchronously.
- void AddLogin(const PasswordForm& form);
+ virtual void AddLogin(const PasswordForm& form);
// Updates the matching PasswordForm in the secure password store (async).
- void UpdateLogin(const PasswordForm& form);
+ virtual void UpdateLogin(const PasswordForm& form);
// Removes the matching PasswordForm from the secure password store (async).
- void RemoveLogin(const PasswordForm& form);
+ virtual void RemoveLogin(const PasswordForm& form);
// Searches for a matching PasswordForm and returns a handle so the async
// request can be tracked. Implement the PasswordStoreConsumer interface to
// be notified on completion.
- int GetLogins(const PasswordForm& form,
- PasswordStoreConsumer* consumer);
+ virtual int GetLogins(const PasswordForm& form,
+ PasswordStoreConsumer* consumer);
// Cancels a previous GetLogins query (async)
virtual void CancelLoginsQuery(int handle);
Property changes on: chrome\browser\password_manager\password_store.h
___________________________________________________________________
Added: svn:eol-style
+ LF

Powered by Google App Engine
This is Rietveld 408576698