Issue 118129: Rename the breakpad file to match the app name instead of just branding name....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118129: Rename the breakpad file to match the app name instead of just branding name.... (Closed)

Created:
11 years, 6 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Rename the breakpad file to match the app name instead of just branding name. Build a tar.bz2 out of the .dsym for archiving. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17433

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	build/mac/dump_app_syms	View		1 chunk	+11 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 6 months ago (2009-06-02 21:28:52 UTC) #2

LG

http://codereview.chromium.org/118129/diff/1/2
File build/mac/dump_app_syms (right):

http://codereview.chromium.org/118129/diff/1/2#newcode33
Line 33: SYMBOL_FILE="${BUILT_PRODUCTS_DIR}/${SRC_APP_NAME}-${FULL_VERSION}
i386.breakpad"
Can we do "-i386" instead of " i386"?

Expand Messages | Collapse Messages