Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Side by Side Diff: build/mac/dump_app_syms

Issue 118129: Rename the breakpad file to match the app name instead of just branding name.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/bin/sh 1 #!/bin/sh
2 2
3 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 # Make sure we got the header to write into passed to us 7 # Make sure we got the header to write into passed to us
8 if [ $# -ne 1 ]; then 8 if [ $# -ne 1 ]; then
9 echo "error: missing branding as an argument" >&2 9 echo "error: missing branding as an argument" >&2
10 exit 1 10 exit 1
(...skipping 12 matching lines...) Expand all
23 BRAND_SCRIPT="${TOP}/build/branding_value.sh" 23 BRAND_SCRIPT="${TOP}/build/branding_value.sh"
24 SRC_APP_NAME=$("${BRAND_SCRIPT}" "${BUILD_BRANDING}" PRODUCT_FULLNAME) 24 SRC_APP_NAME=$("${BRAND_SCRIPT}" "${BUILD_BRANDING}" PRODUCT_FULLNAME)
25 . "${TOP}/chrome/VERSION" 25 . "${TOP}/chrome/VERSION"
26 26
27 BREAKPAD_DUMP_SYMS="${BUILT_PRODUCTS_DIR}/dump_syms" 27 BREAKPAD_DUMP_SYMS="${BUILT_PRODUCTS_DIR}/dump_syms"
28 BREAKPAD_PRODUCT_ID="${BUILD_BRANDING}_Mac" 28 BREAKPAD_PRODUCT_ID="${BUILD_BRANDING}_Mac"
29 FULL_VERSION="${MAJOR}.${MINOR}.${BUILD}.${PATCH}" 29 FULL_VERSION="${MAJOR}.${MINOR}.${BUILD}.${PATCH}"
30 SRC_APP_PATH="${BUILT_PRODUCTS_DIR}/${SRC_APP_NAME}.app" 30 SRC_APP_PATH="${BUILT_PRODUCTS_DIR}/${SRC_APP_NAME}.app"
31 # Created by the build/mac/strip_from_xcode script. 31 # Created by the build/mac/strip_from_xcode script.
32 UNSTRIPPED_APP="${SRC_APP_PATH}.dSYM/Contents/Resources/DWARF/${SRC_APP_NAME}" 32 UNSTRIPPED_APP="${SRC_APP_PATH}.dSYM/Contents/Resources/DWARF/${SRC_APP_NAME}"
33 SYMBOL_FILE="${BUILT_PRODUCTS_DIR}/${BUILD_BRANDING}-${FULL_VERSION} i386.breakp ad" 33 SYMBOL_FILE="${BUILT_PRODUCTS_DIR}/${SRC_APP_NAME}-${FULL_VERSION} i386.breakpad "
Mark Mentovai 2009/06/02 21:28:52 Can we do "-i386" instead of " i386"?
34 34
35 # Only run dump_syms if the file has changed since we last did a dump. 35 # Only run dump_syms if the file has changed since we last did a dump.
36 if [ "${UNSTRIPPED_APP}" -nt "${SYMBOL_FILE}" ] ; then 36 if [ "${UNSTRIPPED_APP}" -nt "${SYMBOL_FILE}" ] ; then
37 "${BREAKPAD_DUMP_SYMS}" -a i386 "${UNSTRIPPED_APP}" > "${SYMBOL_FILE}" 37 "${BREAKPAD_DUMP_SYMS}" -a i386 "${UNSTRIPPED_APP}" > "${SYMBOL_FILE}"
38 fi 38 fi
39
40 DSYM_NAME="${SRC_APP_NAME}.app.dSYM"
41 DSYM_TAR_PATH="${BUILT_PRODUCTS_DIR}/${DSYM_NAME}.tar.bz2"
42
43 # Make a .tar.bz2 out of the .dSYM
44 if [ "${BUILT_PRODUCTS_DIR}/${DSYM_NAME}" -nt "${DSYM_TAR_PATH}" ] ; then
45 # we do a cd so when building the tar, we don't include the build dir in the
46 # tar paths.
47 (cd "${BUILT_PRODUCTS_DIR}" && tar -jcf "${DSYM_TAR_PATH}" "${DSYM_NAME}")
48 fi
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698