Issue 11808: Move port/.../skia/public to skia/ext for Linux. Windows & Mac already moved ...

Issue 11808: Move port/.../skia/public to skia/ext for Linux. Windows & Mac already moved ... (Closed)

Created:
12 years, 1 month ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move port/.../skia/public to skia/ext for Linux. Windows & Mac already moved there. This leaves forwarding headers in base/gfx, which I'll clean up in a future pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5873

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -1473 lines)			Patch
M	base/gfx/bitmap_platform_device.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/gfx/bitmap_platform_device_linux.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/gfx/platform_canvas.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/gfx/platform_canvas_linux.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/gfx/platform_device.h	View	1 chunk	+1 line, -1 line	1 comment	Download
M	base/gfx/platform_device_linux.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/SConscript	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A +	skia/ext/bitmap_platform_device.h	View	1 chunk	+1 line, -1 line	1 comment	Download
A +	skia/ext/bitmap_platform_device_linux.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
A +	skia/ext/bitmap_platform_device_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	skia/ext/platform_canvas.h	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	skia/ext/platform_canvas_linux.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	skia/ext/platform_canvas_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	skia/ext/platform_device_linux.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	skia/ext/platform_device_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/SConscript.port	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	webkit/port/platform/graphics/skia/public/BitmapPlatformDevice.h	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	webkit/port/platform/graphics/skia/public/BitmapPlatformDeviceLinux.h	View	1 chunk	+0 lines, -91 lines	0 comments	Download
D	webkit/port/platform/graphics/skia/public/BitmapPlatformDeviceLinux.cpp	View	1 chunk	+0 lines, -94 lines	0 comments	Download
D	webkit/port/platform/graphics/skia/public/PlatformCanvas.h	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	webkit/port/platform/graphics/skia/public/PlatformCanvasLinux.h	View	1 chunk	+0 lines, -52 lines	0 comments	Download
D	webkit/port/platform/graphics/skia/public/PlatformCanvasLinux.cpp	View	1 chunk	+0 lines, -55 lines	0 comments	Download
D	webkit/port/platform/graphics/skia/public/PlatformCanvas_unittest.cpp	View	1 chunk	+0 lines, -296 lines	0 comments	Download
D	webkit/port/platform/graphics/skia/public/PlatformDevice.h	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	webkit/port/platform/graphics/skia/public/PlatformDeviceLinux.h	View	1 chunk	+0 lines, -25 lines	0 comments	Download
D	webkit/port/platform/graphics/skia/public/PlatformDeviceLinux.cpp	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	webkit/port/platform/graphics/skia/public/README	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	webkit/port/platform/graphics/skia/public/VectorDevice.h	View	1 chunk	+0 lines, -119 lines	0 comments	Download
D	webkit/port/platform/graphics/skia/public/VectorDevice.cpp	View	1 chunk	+0 lines, -612 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

12 years, 1 month ago (2008-11-22 00:00:57 UTC) #2

A few nits below, otherwise, LGTM.

http://codereview.chromium.org/11808/diff/1/29
File base/gfx/platform_device.h (right):

http://codereview.chromium.org/11808/diff/1/29#newcode7
Line 7: #include "skia/ext/platform_device.h"
Nit: Should this file have include guards?

http://codereview.chromium.org/11808/diff/1/19
File skia/ext/bitmap_platform_device.h (right):

http://codereview.chromium.org/11808/diff/1/19#newcode24
Line 24: #include "skia/ext/bitmap_platform_device_mac.h"
I think you mean linux.

Expand Messages | Collapse Messages