Add some basic validation of the msvs_guid to require upper-case hex...

Add some basic validation of the msvs_guid to require upper-case hex
characters.

If there are lower case hex characters, IncrediBuild BuildConsole's
parsing logic will think the guid is valid, but silently skip building
the target causing hard to track build failures.  This check works around
the issue by bailing out earlier.

[awong, 2009-05-29 19:44:05]

This the real CL.

[bradn, 2009-05-29 19:51:32]

Other than some nits. LGTM

http://codereview.chromium.org/118021/diff/1002/3
File pylib/gyp/generator/msvs.py (right):

http://codereview.chromium.org/118021/diff/1002/3#newcode17
Line 17: # IncrediBuild BuildConsol will parse the solution file, but then
BuildConsole

http://codereview.chromium.org/118021/diff/1002/3#newcode20
Line 20: # if IncrediBuild is executed from inside Visual Stuiod.  This regex
Studio

http://codereview.chromium.org/118021/diff/1002/3#newcode442
Line 442: (guid, VALID_MSVS_GUID_CHARS.pattern))
By the python style guid, this line should be indented up to the '.

[awong, 2009-05-29 21:22:29]

All fixed.

Pushing through try servers, and assuming those are good, will submit.

http://codereview.chromium.org/118021/diff/1002/3
File pylib/gyp/generator/msvs.py (right):

http://codereview.chromium.org/118021/diff/1002/3#newcode17
Line 17: # IncrediBuild BuildConsol will parse the solution file, but then
On 2009/05/29 19:51:33, bradn wrote:
> BuildConsole

fixed

http://codereview.chromium.org/118021/diff/1002/3#newcode20
Line 20: # if IncrediBuild is executed from inside Visual Stuiod.  This regex
On 2009/05/29 19:51:33, bradn wrote:
> Studio

fixed

http://codereview.chromium.org/118021/diff/1002/3#newcode442
Line 442: (guid, VALID_MSVS_GUID_CHARS.pattern))
On 2009/05/29 19:51:33, bradn wrote:
> By the python style guid, this line should be indented up to the '.
> 
> 

fixed

[awong, 2009-05-30 14:56:37]

Forgot gyp isn't in the chromium repository.  I hacked the patch through the try
server and they all succeeded.

Could someone land this for me?

Thanks,
Albert

[awong, 2009-05-31 06:02:07]

Landed by Brad in gyp r506.

Closing issue.

Thanks Brad!