Add some basic validation of the msvs_guid to require upper-case hex...

pylib/gyp/generator/msvs.py

 #!/usr/bin/python
 
 
 import os
 import re
 import subprocess
 import sys
 import gyp.common
 import gyp.MSVSNew as MSVSNew
 import gyp.MSVSToolFile as MSVSToolFile
 import gyp.MSVSProject as MSVSProject
 import gyp.MSVSVersion as MSVSVersion
 
 
+# Regular expression for validating Visual Studio GUIDs.  If the GUID
+# contains lowercase hex letters, MSVS will be fine. However,
+# IncrediBuild BuildConsole will parse the solution file, but then
+# silently skip building the target causing hard to track down errors.
+# Note that this only happens with the BuildConsole, and does not occur
+# if IncrediBuild is executed from inside Visual Studio.  This regex
+# validates that the string looks like a GUID with all uppercase hex
+# letters.
+VALID_MSVS_GUID_CHARS = re.compile('^[A-F0-9\-]+$')
+
+
 generator_default_variables = {
     'EXECUTABLE_PREFIX': '',
     'EXECUTABLE_SUFFIX': '.exe',
     'INTERMEDIATE_DIR': '$(IntDir)',
     'SHARED_INTERMEDIATE_DIR': '$(OutDir)/obj/global_intermediate',
     'OS': 'win',
     'PRODUCT_DIR': '$(OutDir)',
     'RULE_INPUT_ROOT': '$(InputName)',
     'RULE_INPUT_EXT': '$(InputExt)',
     'RULE_INPUT_NAME': '$(InputFileName)',
@@ skipping 393 matching lines @@
   Arguments:
     vcproj_filename: Filename of the vcproj file to generate.
     build_file: Filename of the .gyp file that the vcproj file comes from.
     spec: The target dictionary containing the properties of the target.
   """
   #print 'Generating %s' % vcproj_filename
 
   p = MSVSProject.Writer(vcproj_filename, version=version)
   default_config = spec['configurations'][spec['default_configuration']]
   guid = default_config.get('msvs_guid')
-  if guid: guid = '{%s}' % guid
+  if guid:
+    if VALID_MSVS_GUID_CHARS.match(guid) == None:
+      raise ValueError('Invalid MSVS guid: "%s".  Must match regex: "%s".' %
+                       (guid, VALID_MSVS_GUID_CHARS.pattern))
+
+    guid = '{%s}' % guid
   p.Create(spec['target_name'], guid=guid)
 
   # Get directory project file is in.
   gyp_dir = os.path.split(vcproj_filename)[0]
 
   # Pick target configuration type.
   config_type = {
       'executable': '1',
       'shared_library': '2',
       'loadable_module': '2',
@@ skipping 409 matching lines @@
       _ProjectObject(sln_path, p, project_objs, projects)
     # Create folder hierarchy.
     root_entries = _GatherSolutionFolders(project_objs)
     # Create solution.
     sln = MSVSNew.MSVSSolution(sln_path,
                                entries=root_entries,
                                variants=configs,
                                websiteProperties=False,
                                version=msvs_version)
     sln.Write()