Issue 118010: Add duplicate 'conditions' blocks that define the '<(BRANDING)'...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118010: Add duplicate 'conditions' blocks that define the '<(BRANDING)'... (Closed)

Created:
11 years, 6 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, Michael Moss

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add duplicate 'conditions' blocks that define the '<(BRANDING)' variable for the 'OS=="win"' targets that use it, to work around an apparent problem in the gyp variable expansion. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17208

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -0 lines)			Patch
	M	chrome/installer/installer.gyp	View		2 chunks	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 6 months ago (2009-05-29 18:06:08 UTC) #2

LGTM.  Call 'em TODO(mark) since that's who I am to the chromium.org world. 
I'll work on the reduced testcase in the GYP issue tracker.

Expand Messages | Collapse Messages