Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: chrome/installer/installer.gyp

Issue 118010: Add duplicate 'conditions' blocks that define the '<(BRANDING)'... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 'variables': { 2 'variables': {
3 'version_py': '../../chrome/tools/build/version.py', 3 'version_py': '../../chrome/tools/build/version.py',
4 'VERSION': '../../chrome/VERSION', 4 'VERSION': '../../chrome/VERSION',
5 # 'BRANDING' is set in the 'conditions' section at the bottom. 5 # 'BRANDING' is set in the 'conditions' section at the bottom.
6 }, 6 },
7 'includes': [ 7 'includes': [
8 '../../build/common.gypi', 8 '../../build/common.gypi',
9 ], 9 ],
10 'targets': [ 10 'targets': [
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 'python', 388 'python',
389 '<(create_installer_archive_py_path)', 389 '<(create_installer_archive_py_path)',
390 '--output_dir=<(PRODUCT_DIR)', 390 '--output_dir=<(PRODUCT_DIR)',
391 '--input_file=<(RULE_INPUT_PATH)', 391 '--input_file=<(RULE_INPUT_PATH)',
392 # TODO(sgk): may just use environment variables 392 # TODO(sgk): may just use environment variables
393 #'--distribution=$(CHROMIUM_BUILD)', 393 #'--distribution=$(CHROMIUM_BUILD)',
394 '--distribution=_google_chrome', 394 '--distribution=_google_chrome',
395 ], 395 ],
396 }, 396 },
397 ], 397 ],
398 # TODO(mmentovai): <(BRANDING) should be defined by the
399 # global condition block at the bottom of the file, but
400 # this doesn't work due to the following issue:
401 #
402 # http://code.google.com/p/gyp/issues/detail?id=22
403 #
404 # Remove this block once the above issue is fixed.
405 'conditions': [
406 [ 'branding == "Chrome"', {
407 'variables': {
408 'BRANDING': '../../chrome/app/theme/google_chrome/BRANDING',
409 },
410 }, { # else branding!="Chrome"
411 'variables': {
412 'BRANDING': '../../chrome/app/theme/chromium/BRANDING',
413 },
414 }],
415 ],
398 }, 416 },
399 { 417 {
400 'target_name': 'mini_installer_test', 418 'target_name': 'mini_installer_test',
401 'type': 'executable', 419 'type': 'executable',
402 'msvs_guid': '4B6E199A-034A-49BD-AB93-458DD37E45B1', 420 'msvs_guid': '4B6E199A-034A-49BD-AB93-458DD37E45B1',
403 'dependencies': [ 421 'dependencies': [
404 'installer_util', 422 'installer_util',
405 '../../base/base.gyp:base', 423 '../../base/base.gyp:base',
406 '../../testing/gtest.gyp:gtest', 424 '../../testing/gtest.gyp:gtest',
407 ], 425 ],
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 '<(scan_server_dlls_py)', 532 '<(scan_server_dlls_py)',
515 '--output_dir=<(INTERMEDIATE_DIR)', 533 '--output_dir=<(INTERMEDIATE_DIR)',
516 '--input_file=<(RULE_INPUT_PATH)', 534 '--input_file=<(RULE_INPUT_PATH)',
517 '--header_output_dir=<(INTERMEDIATE_DIR)', 535 '--header_output_dir=<(INTERMEDIATE_DIR)',
518 # TODO(sgk): may just use environment variables 536 # TODO(sgk): may just use environment variables
519 #'--distribution=$(CHROMIUM_BUILD)', 537 #'--distribution=$(CHROMIUM_BUILD)',
520 '--distribution=_google_chrome', 538 '--distribution=_google_chrome',
521 ], 539 ],
522 }, 540 },
523 ], 541 ],
542 # TODO(mmentovai): <(BRANDING) should be defined by the
543 # global condition block at the bottom of the file, but
544 # this doesn't work due to the following issue:
545 #
546 # http://code.google.com/p/gyp/issues/detail?id=22
547 #
548 # Remove this block once the above issue is fixed.
549 'conditions': [
550 [ 'branding == "Chrome"', {
551 'variables': {
552 'BRANDING': '../../chrome/app/theme/google_chrome/BRANDING',
553 },
554 }, { # else branding!="Chrome"
555 'variables': {
556 'BRANDING': '../../chrome/app/theme/chromium/BRANDING',
557 },
558 }],
559 ],
524 }, 560 },
525 ], 561 ],
526 }], 562 }],
527 [ 'branding == "Chrome"', { 563 [ 'branding == "Chrome"', {
528 'variables': { 564 'variables': {
529 'BRANDING': '../../chrome/app/theme/google_chrome/BRANDING', 565 'BRANDING': '../../chrome/app/theme/google_chrome/BRANDING',
530 }, 566 },
531 }, { # else branding!="Chrome" 567 }, { # else branding!="Chrome"
532 'variables': { 568 'variables': {
533 'BRANDING': '../../chrome/app/theme/chromium/BRANDING', 569 'BRANDING': '../../chrome/app/theme/chromium/BRANDING',
534 }, 570 },
535 }], 571 }],
536 ], 572 ],
537 } 573 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698