DevTools: Add 'Enable Developer Tools' option into the Advanced tab. Hide dev...

DevTools: Add 'Enable Developer Tools' option into the Advanced tab. Hide developer tools by default.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16984

[yurys, 2009-05-27 13:56:04]

LGTM

http://codereview.chromium.org/117003/diff/4019/5006
File chrome/browser/views/options/advanced_contents_view.cc (right):

http://codereview.chromium.org/117003/diff/4019/5006#newcode1054
Line 1054: class DevToolsSection : public AdvancedSection,
enclose the class in anonymous namespace

[pfeldman, 2009-05-27 14:12:54]

http://codereview.chromium.org/117003/diff/4019/5006
File chrome/browser/views/options/advanced_contents_view.cc (right):

http://codereview.chromium.org/117003/diff/4019/5006#newcode1054
Line 1054: class DevToolsSection : public AdvancedSection,
On 2009/05/27 13:56:04, Yury Semikhatsky wrote:
> enclose the class in anonymous namespace

Done.

[Ben Goodger (Google), 2009-05-27 19:34:39]

The UI team has not agreed to any options being added here. Please revert this
change immediately.

If you want to add UI for Developer items, there is a "Developer" menu under the
page menu where you can add additional options. If the feature you're working on
isn't ready for prime time and is default to off, use a command line flag
instead of an option.

-Ben

On 2009/05/27 14:12:54, pfeldman wrote:
> http://codereview.chromium.org/117003/diff/4019/5006
> File chrome/browser/views/options/advanced_contents_view.cc (right):
> 
> http://codereview.chromium.org/117003/diff/4019/5006#newcode1054
> Line 1054: class DevToolsSection : public AdvancedSection,
> On 2009/05/27 13:56:04, Yury Semikhatsky wrote:
> > enclose the class in anonymous namespace
> 
> Done.

[pfeldman, 2009-05-27 19:50:44]

Sorry about that, I am new to this process, so I will need some education. What
is 'UI team' and how do I get in touch with it? There is a context I would like
to provide the team with - maybe they find my approach reasonable. Is it
strictly required that the change is reverted 'immediately' or can I 'fix' it
once I get to the agreement with the 'UI team'?

Thanks
Pavel