DevTools: Add 'Enable Developer Tools' option into the Advanced tab. Hide dev...

chrome/browser/views/options/advanced_contents_view.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/options/advanced_contents_view.h"
 
 #include <windows.h>
 
 #include <cryptuiapi.h>
 #pragma comment(lib, "cryptui.lib")
@@ skipping 55 matching lines @@
     HDC dc = canvas->beginPlatformPaint();
     RECT native_lb = view->GetLocalBounds(true).ToRECT();
     gfx::NativeTheme::instance()->PaintListBackground(dc, true, &native_lb);
     canvas->endPlatformPaint();
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ListBackground);
 };
 
-}  // namespace
 ////////////////////////////////////////////////////////////////////////////////
 // AdvancedSection
 //  A convenience view for grouping advanced options together into related
 //  sections.
 //
 class AdvancedSection : public OptionsPageView {
  public:
   AdvancedSection(Profile* profile, const std::wstring& title);
   virtual ~AdvancedSection() {}
 
@@ skipping 848 matching lines @@
     } else {
       enable_ssl2_checkbox_->SetEnabled(false);
       check_for_cert_revocation_checkbox_->SetEnabled(false);
     }
   }
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // NetworkSection
 
-namespace {
-
 // A helper method that opens the Internet Options control panel dialog with
 // the Connections tab selected.
 class OpenConnectionDialogTask : public Task {
  public:
   OpenConnectionDialogTask() {}
 
   virtual void Run() {
     // Using rundll32 seems better than LaunchConnectionDialog which causes a
     // new dialog to be made for each call.  rundll32 uses the same global
     // dialog and it seems to share with the shortcut in control panel.
@@ skipping 14 matching lines @@
     args.append(inetcpl);
 
     ShellExecute(NULL, L"open", rundll32.c_str(), args.c_str(), NULL,
         SW_SHOWNORMAL);
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(OpenConnectionDialogTask);
 };
 
-}  // namespace
-
 class NetworkSection : public AdvancedSection,
                        public views::ButtonListener {
  public:
   explicit NetworkSection(Profile* profile);
   virtual ~NetworkSection() {}
 
   // Overridden from views::ButtonListener:
   virtual void ButtonPressed(views::Button* sender);
 
  protected:
@@ skipping 49 matching lines @@
   AddWrappingLabelRow(layout, change_proxies_label_, single_column_view_set_id,
                       true);
   AddLeadingControl(layout, change_proxies_button_, indented_view_set_id,
                     false);
 }
 
 void NetworkSection::NotifyPrefChanged(const std::wstring* pref_name) {
 }
 
 ////////////////////////////////////////////////////////////////////////////////
+// DevToolsSection
+
+class DevToolsSection : public AdvancedSection,
+                        public views::ButtonListener {
+ public:
+  explicit DevToolsSection(Profile* profile);
+  virtual ~DevToolsSection() {}
+
+  // Overridden from views::ButtonListener:
+  virtual void ButtonPressed(views::Button* sender);
+
+ protected:
+  // OptionsPageView overrides:
+  virtual void InitControlLayout();
+  virtual void NotifyPrefChanged(const std::wstring* pref_name);
+
+ private:
+  // Controls for this section:
+  views::Checkbox* enable_devtools_checkbox_;
+
+  // Preferences for this section:
+  BooleanPrefMember enable_devtools_;
+
+  DISALLOW_COPY_AND_ASSIGN(DevToolsSection);
+};
+
+DevToolsSection::DevToolsSection(Profile* profile)
+    : enable_devtools_checkbox_(NULL),
+      AdvancedSection(profile,
+          l10n_util::GetString(IDS_OPTIONS_ADVANCED_SECTION_TITLE_DEVTOOLS)) {
+}
+
+void DevToolsSection::ButtonPressed(views::Button* sender) {
+  if (sender == enable_devtools_checkbox_) {
+    bool enabled = enable_devtools_checkbox_->checked();
+    UserMetricsRecordAction(enabled ?
+                                L"Options_DevToolsCheckbox_Enable" :
+                                L"Options_DevToolsCheckbox_Disable",
+                            profile()->GetPrefs());
+    enable_devtools_.SetValue(enabled);
+  }
+}
+
+void DevToolsSection::InitControlLayout() {
+  AdvancedSection::InitControlLayout();
+
+  enable_devtools_checkbox_ = new views::Checkbox(
+      l10n_util::GetString(IDS_OPTIONS_ENABLE_DEVTOOLS));
+  enable_devtools_checkbox_->set_listener(this);
+
+  GridLayout* layout = new GridLayout(contents_);
+  contents_->SetLayoutManager(layout);
+
+  const int single_column_view_set_id = 0;
+  AddWrappingColumnSet(layout, single_column_view_set_id);
+
+  AddWrappingCheckboxRow(layout, enable_devtools_checkbox_,
+                         single_column_view_set_id, false);
+
+  // Init member prefs so we can update the controls if prefs change.
+  enable_devtools_.Init(prefs::kWebKitDeveloperExtrasEnabled,
+                        profile()->GetPrefs(), this);
+}
+
+void DevToolsSection::NotifyPrefChanged(const std::wstring* pref_name) {
+  if (!pref_name || *pref_name == prefs::kWebKitDeveloperExtrasEnabled) {
+    enable_devtools_checkbox_->SetChecked(
+        enable_devtools_.GetValue());
+  }
+}
+
+}  // namespace
+
+////////////////////////////////////////////////////////////////////////////////
 // AdvancedContentsView
 
 class AdvancedContentsView : public OptionsPageView {
  public:
   explicit AdvancedContentsView(Profile* profile);
   virtual ~AdvancedContentsView();
 
   // views::View overrides:
   virtual int GetLineScrollIncrement(views::ScrollView* scroll_view,
                                      bool is_horizontal, bool is_positive);
@@ skipping 72 matching lines @@
                         GridLayout::USE_PREF, 0, 0);
 
   layout->StartRow(0, single_column_view_set_id);
   layout->AddView(new PrivacySection(profile()));
   layout->StartRow(0, single_column_view_set_id);
   layout->AddView(new NetworkSection(profile()));
   layout->StartRow(0, single_column_view_set_id);
   layout->AddView(new WebContentSection(profile()));
   layout->StartRow(0, single_column_view_set_id);
   layout->AddView(new SecuritySection(profile()));
+  layout->StartRow(0, single_column_view_set_id);
+  layout->AddView(new DevToolsSection(profile()));
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // AdvancedContentsView, private:
 
 void AdvancedContentsView::InitClass() {
   static bool initialized = false;
   if (!initialized) {
     ResourceBundle& rb = ResourceBundle::GetSharedInstance();
     line_height_ = rb.GetFont(ResourceBundle::BaseFont).height();
@@ skipping 20 matching lines @@
 
 void AdvancedScrollViewContainer::Layout() {
   gfx::Rect lb = GetLocalBounds(false);
 
   gfx::Size border = gfx::NativeTheme::instance()->GetThemeBorderSize(
       gfx::NativeTheme::LIST);
   lb.Inset(border.width(), border.height());
   scroll_view_->SetBounds(lb);
   scroll_view_->Layout();
 }