Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Unified Diff: chrome/browser/external_tab_container.cc

Issue 115943: Avoid DCHECKING on NEW_FOREGROUND_TAB and NEW_BACKGROUND_TAB dispositions in ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/external_tab_container.cc
===================================================================
--- chrome/browser/external_tab_container.cc (revision 17189)
+++ chrome/browser/external_tab_container.cc (working copy)
@@ -130,7 +130,7 @@
bool ExternalTabContainer::IsExternalTabContainer(HWND window) {
if (GetProp(window, kWindowObjectKey) != NULL)
return true;
-
+
return false;
}
@@ -186,7 +186,8 @@
WindowOpenDisposition disposition,
const gfx::Rect& initial_pos,
bool user_gesture) {
- if (disposition == NEW_POPUP || disposition == NEW_WINDOW) {
+ if (disposition == NEW_POPUP || disposition == NEW_WINDOW ||
+ disposition == NEW_FOREGROUND_TAB || disposition == NEW_BACKGROUND_TAB) {
Browser::BuildPopupWindowHelper(source, new_contents, initial_pos,
Browser::TYPE_POPUP,
tab_contents_->profile(), true);
@@ -235,7 +236,7 @@
void ExternalTabContainer::ForwardMessageToExternalHost(
const std::string& message, const std::string& origin,
const std::string& target) {
- if(automation_) {
+ if (automation_) {
automation_->Send(
new AutomationMsg_ForwardMessageToExternalHost(0, tab_handle_,
message, origin, target));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698