Avoid DCHECKING on NEW_FOREGROUND_TAB and NEW_BACKGROUND_TAB dispositions in ...

chrome/browser/external_tab_container.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/external_tab_container.h"
 
 #include "app/win_util.h"
 #include "base/logging.h"
 #include "base/win_util.h"
 #include "chrome/browser/automation/automation_provider.h"
@@ skipping 112 matching lines @@
   if (tab_contents_) {
     static_cast<TabContents*>(tab_contents_)->Focus();
     static_cast<TabContents*>(tab_contents_)->SetInitialFocus(reverse);
   }
 }
 
 // static
 bool ExternalTabContainer::IsExternalTabContainer(HWND window) {
   if (GetProp(window, kWindowObjectKey) != NULL)
     return true;
-  
+
   return false;
 }
 
 // static
 ExternalTabContainer* ExternalTabContainer::GetContainerForTab(
     HWND tab_window) {
   HWND parent_window = ::GetParent(tab_window);
   if (!::IsWindow(parent_window)) {
     return NULL;
   }
@@ skipping 35 matching lines @@
     automation_->Send(new AutomationMsg_NavigationStateChanged(0, tab_handle_,
                                                                changed_flags));
   }
 }
 
 void ExternalTabContainer::AddNewContents(TabContents* source,
                             TabContents* new_contents,
                             WindowOpenDisposition disposition,
                             const gfx::Rect& initial_pos,
                             bool user_gesture) {
-  if (disposition == NEW_POPUP || disposition == NEW_WINDOW) {
+  if (disposition == NEW_POPUP || disposition == NEW_WINDOW ||
+      disposition == NEW_FOREGROUND_TAB || disposition == NEW_BACKGROUND_TAB) {
     Browser::BuildPopupWindowHelper(source, new_contents, initial_pos,
                                     Browser::TYPE_POPUP,
                                     tab_contents_->profile(), true);
   } else {
     NOTREACHED();
   }
 }
 
 void ExternalTabContainer::ActivateContents(TabContents* contents) {
 }
@@ skipping 28 matching lines @@
 void ExternalTabContainer::ContentsZoomChange(bool zoom_in) {
 }
 
 void ExternalTabContainer::ToolbarSizeChanged(TabContents* source,
                                               bool finished) {
 }
 
 void ExternalTabContainer::ForwardMessageToExternalHost(
     const std::string& message, const std::string& origin,
     const std::string& target) {
-  if(automation_) {
+  if (automation_) {
     automation_->Send(
         new AutomationMsg_ForwardMessageToExternalHost(0, tab_handle_,
             message, origin, target));
   }
 }
 
 ExtensionFunctionDispatcher* ExternalTabContainer::
     CreateExtensionFunctionDispatcher(RenderViewHost* render_view_host,
                                       const std::string& extension_id) {
   return new ExtensionFunctionDispatcher(render_view_host, NULL, extension_id);
@@ skipping 140 matching lines @@
     NotificationService::current()->Notify(
         NotificationType::EXTERNAL_TAB_CLOSED,
         Source<NavigationController>(&tab_contents_->controller()),
         Details<ExternalTabContainer>(this));
 
     delete tab_contents_;
     tab_contents_ = NULL;
   }
 }