Ignore the insert key so we don't switch into overtype mode (which surprises ...

Ignore the insert key so we don't switch into overtype mode (which surprises users since there's no indicator of it).

BUG=6856
TEST=In Omnibox or in a native textfield (e.g. the "Add a site" URL field for the Options dialog's "Open these sites at startup" pref), type text, set cursor at beginning, hit insert, and type.  Your text should prepend to the existing text instead of replacing it.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17231

[Finnur, 2011-03-25 14:44:00]

http://codereview.chromium.org/115934/diff/1/views/controls/textfield/native_...
File views/controls/textfield/native_textfield_win.cc (right):

http://codereview.chromium.org/115934/diff/1/views/controls/textfield/native_...
views/controls/textfield/native_textfield_win.cc:426: return;
Peter, did you mean to add a break statement here as well or do you want this to
fall into the |case 'V'| clause below if the 'if' statement is false?

(CID: 4210)

[Peter Kasting, 2011-03-25 19:25:12]

http://codereview.chromium.org/115934/diff/1/views/controls/textfield/native_...
File views/controls/textfield/native_textfield_win.cc (right):

http://codereview.chromium.org/115934/diff/1/views/controls/textfield/native_...
views/controls/textfield/native_textfield_win.cc:426: return;
On 2011/03/25 14:44:00, Finnur wrote:
> Peter, did you mean to add a break statement here as well or do you want this
to
> fall into the |case 'V'| clause below if the 'if' statement is false?

The latter.  Shift-insert == ctrl-v.  See also how the previous code was a
direct fallthrough with no conditional.

[Finnur, 2011-03-25 19:27:57]

http://codereview.chromium.org/115934/diff/1/views/controls/textfield/native_...
File views/controls/textfield/native_textfield_win.cc (right):

http://codereview.chromium.org/115934/diff/1/views/controls/textfield/native_...
views/controls/textfield/native_textfield_win.cc:426: return;
Excellent. I guess I'll add a comment here for future generations. Thanks.

On 2011/03/25 19:25:12, Peter Kasting wrote:
> On 2011/03/25 14:44:00, Finnur wrote:
> > Peter, did you mean to add a break statement here as well or do you want
this
> to
> > fall into the |case 'V'| clause below if the 'if' statement is false?
> 
> The latter.  Shift-insert == ctrl-v.  See also how the previous code was a
> direct fallthrough with no conditional.