Ignore the insert key so we don't switch into overtype mode (which surprises ...

views/controls/textfield/native_textfield_win.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/l10n_util.h"
 #include "app/l10n_util_win.h"
 #include "app/win_util.h"
 #include "base/clipboard.h"
 #include "base/gfx/native_theme.h"
 #include "base/scoped_clipboard_writer.h"
@@ skipping 402 matching lines @@
       return;
 
     case 'C':
       if ((flags & KF_ALTDOWN) || (GetKeyState(VK_CONTROL) >= 0))
         break;
       if (GetKeyState(VK_SHIFT) >= 0)
         Copy();
       return;
 
     case VK_INSERT:
+      // Ignore insert by itself, so we don't turn overtype mode on/off.
+      if (!(flags & KF_ALTDOWN) && (GetKeyState(VK_SHIFT) >= 0) &&
+          (GetKeyState(VK_CONTROL) >= 0))
+        return;

[Finnur, 2011/03/25 14:44:00]

Peter, did you mean to add a break statement here as well or do you want this to
fall into the |case 'V'| clause below if the 'if' statement is false?

(CID: 4210)

[Peter Kasting, 2011/03/25 19:25:12]

The latter.  Shift-insert == ctrl-v.  See also how the previous code was a
direct fallthrough with no conditional.

[Finnur, 2011/03/25 19:27:57]

Excellent. I guess I'll add a comment here for future generations. Thanks.

On 2011/03/25 19:25:12, Peter Kasting wrote:

     case 'V':
       if ((flags & KF_ALTDOWN) ||
           (GetKeyState((key == 'V') ? VK_CONTROL : VK_SHIFT) >= 0))
         break;
       if (GetKeyState((key == 'V') ? VK_SHIFT : VK_CONTROL) >= 0) {
         ScopedFreeze freeze(this, GetTextObjectModel());
         OnBeforePossibleChange();
         Paste();
         OnAfterPossibleChange();
       }
@@ skipping 390 matching lines @@
 ////////////////////////////////////////////////////////////////////////////////
 // NativeTextfieldWrapper, public:
 
 // static
 NativeTextfieldWrapper* NativeTextfieldWrapper::CreateWrapper(
     Textfield* field) {
   return new NativeTextfieldWin(field);
 }
 
 }  // namespace views