Issue 115868: The CPP logic on the log dir seems to have been wrong since last year. Chang...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115868: The CPP logic on the log dir seems to have been wrong since last year. Chang... (Closed)

Created:
11 years, 7 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

The CPP logic on the log dir seems to have been wrong since last year. Changed so debug writes next to the executable, and release writes to userdata dir. It was the reverse. Drop two paths that aren't used any more. BUG=12834 TEST=run app, make sure we don't create a log file inside the MacOS folder. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17087

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -23 lines)			Patch
	M	chrome/common/chrome_paths.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	chrome/common/chrome_paths.cc	View		2 chunks	+3 lines, -21 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM. Looks like the test server and python paths moved into net/base/ssl_test_util.cc.

11 years, 7 months ago (2009-05-28 18:04:19 UTC) #2

r=me

Expand Messages | Collapse Messages