Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2057)

Unified Diff: chrome/common/chrome_paths.cc

Issue 115868: The CPP logic on the log dir seems to have been wrong since last year. Chang... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_paths.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_paths.cc
===================================================================
--- chrome/common/chrome_paths.cc (revision 17079)
+++ chrome/common/chrome_paths.cc (working copy)
@@ -37,9 +37,11 @@
case chrome::DIR_APP:
return PathService::Get(base::DIR_MODULE, result);
case chrome::DIR_LOGS:
-#ifndef NDEBUG
+#ifdef NDEBUG
+ // Release builds write to the data dir
return PathService::Get(chrome::DIR_USER_DATA, result);
#else
+ // Debug builds write next to the binary (in the build tree)
return PathService::Get(base::DIR_EXE, result);
#endif
case chrome::FILE_RESOURCE_MODULE:
@@ -161,26 +163,6 @@
if (!file_util::PathExists(cur)) // we don't want to create this
return false;
break;
- case chrome::FILE_PYTHON_RUNTIME:
- if (!PathService::Get(base::DIR_SOURCE_ROOT, &cur))
- return false;
- cur = cur.Append(FILE_PATH_LITERAL("third_party"));
- cur = cur.Append(FILE_PATH_LITERAL("python_24"));
- cur = cur.Append(FILE_PATH_LITERAL("python.exe"));
- if (!file_util::PathExists(cur)) // we don't want to create this
- return false;
- break;
- case chrome::FILE_TEST_SERVER:
- if (!PathService::Get(base::DIR_SOURCE_ROOT, &cur))
- return false;
- cur = cur.Append(FILE_PATH_LITERAL("net"));
- cur = cur.Append(FILE_PATH_LITERAL("tools"));
- cur = cur.Append(FILE_PATH_LITERAL("test"));
- cur = cur.Append(FILE_PATH_LITERAL("testserver"));
- cur = cur.Append(FILE_PATH_LITERAL("testserver.py"));
- if (!file_util::PathExists(cur)) // we don't want to create this
- return false;
- break;
default:
return false;
}
« no previous file with comments | « chrome/common/chrome_paths.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698