DevTools: pass class and method name as arguments to RPC messages

DevTools: decouple class and method names from RPC message arguments. That would allow to select dispatcher wothout parsing the message argument.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17176

[pfeldman, 2009-05-28 16:42:23]

This looks good once corresponding tests are fixed.

http://codereview.chromium.org/115862/diff/29/1032
File webkit/glue/devtools/js/devtools.js (right):

http://codereview.chromium.org/115862/diff/29/1032#newcode27
Line 27: debugPrint(remoteName + '.' + methodName + '('  + (typeof msg)
/*JSON.stringify(msg)*/ + ')');
remove this please.

http://codereview.chromium.org/115862/diff/29/1032#newcode39
Line 39: method.apply(this, msg);
bring things back please.

http://codereview.chromium.org/115862/diff/29/1035
File webkit/glue/webdevtoolsclient_impl.cc (right):

http://codereview.chromium.org/115862/diff/29/1035#newcode129
Line 129: "devtools.dispatch('%s','%s',%s)", class_name.c_str(),
formatting

[apavlov, 2009-05-28 17:35:27]

LGTM on my side provided you fixed it correctly.

[yurys, 2009-05-29 06:21:46]

http://codereview.chromium.org/115862/diff/29/1032
File webkit/glue/devtools/js/devtools.js (right):

http://codereview.chromium.org/115862/diff/29/1032#newcode27
Line 27: debugPrint(remoteName + '.' + methodName + '('  + (typeof msg)
/*JSON.stringify(msg)*/ + ')');
On 2009/05/28 16:42:23, pfeldman wrote:
> remove this please.

Done.

http://codereview.chromium.org/115862/diff/29/1032#newcode39
Line 39: method.apply(this, msg);
On 2009/05/28 16:42:23, pfeldman wrote:
> bring things back please.

Done.

http://codereview.chromium.org/115862/diff/29/1035
File webkit/glue/webdevtoolsclient_impl.cc (right):

http://codereview.chromium.org/115862/diff/29/1035#newcode129
Line 129: "devtools.dispatch('%s','%s',%s)", class_name.c_str(),
On 2009/05/28 16:42:23, pfeldman wrote:
> formatting

Done.

[yurys, 2009-05-29 07:53:32]

Fixed unittests.