Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2522)

Unified Diff: webkit/glue/devtools/js/devtools.js

Issue 115862: DevTools: pass class and method name as arguments to RPC messages (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/devtools/devtools_rpc_unittest.cc ('k') | webkit/glue/webdevtoolsagent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/devtools/js/devtools.js
===================================================================
--- webkit/glue/devtools/js/devtools.js (revision 17071)
+++ webkit/glue/devtools/js/devtools.js (working copy)
@@ -15,12 +15,12 @@
/**
* Dispatches raw message from the host.
+ * @param {string} remoteName
+ * @prama {string} methodName
* @param {Object} msg Message to dispatch.
*/
-devtools.dispatch = function(msg) {
- var delegate = msg[0];
- var methodName = msg[1];
- var remoteName = 'Remote' + delegate.substring(0, delegate.length - 8);
+devtools.dispatch = function(remoteName, methodName, msg) {
+ remoteName = 'Remote' + remoteName.substring(0, remoteName.length - 8);
var agent = window[remoteName];
if (!agent) {
debugPrint('No remote agent "' + remoteName + '" found.');
@@ -31,7 +31,7 @@
debugPrint('No method "' + remoteName + '.' + methodName + '" found.');
return;
}
- method.apply(this, msg.slice(2));
+ method.apply(this, msg);
};
« no previous file with comments | « webkit/glue/devtools/devtools_rpc_unittest.cc ('k') | webkit/glue/webdevtoolsagent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698