Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1158006: Enter chroot can return an error code on cleanup. We make cleanup best effort (Closed)

Created:
10 years, 9 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
davidjames
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Enter chroot can return an error code on cleanup. We make cleanup best effort

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/scripts/enter_chroot.sh View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sosa
10 years, 9 months ago (2010-03-23 18:07:15 UTC) #1
davidjames
10 years, 9 months ago (2010-03-23 18:13:52 UTC) #2
LGTM, as this will give us more insight into whether the setup_board failures on
the buildbot are just due to some minor cleanup issues.

Long term, we should look into why the cleanup routine is failing occasionally
and see if we can implement a more robust solution.

Powered by Google App Engine
This is Rietveld 408576698