src/scripts/enter_chroot.sh - Issue 1158006: Enter chroot can return an error code on cleanup. We make cleanup best effort

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/scripts/enter_chroot.sh

Issue 1158006: Enter chroot can return an error code on cleanup. We make cleanup best effort (Closed)

Patch Set: Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/scripts/enter_chroot.sh

diff --git a/src/scripts/enter_chroot.sh b/src/scripts/enter_chroot.sh

index 00b9e647946a0c9aca588af00f9459171e24fb28..3c196a93136cd46c1c2257dd383092646308cd2c 100755

--- a/src/scripts/enter_chroot.sh

+++ b/src/scripts/enter_chroot.sh

@@ -134,6 +134,10 @@ function setup_env {

function teardown_env {

# Only teardown if we're the last enter_chroot to die

+ # We should not return with an error if cleanup has an error. Cleanup is

+ # best effort only.

+ set +e

(

flock 200

« no previous file with comments | « no previous file | no next file » | no next file with comments »