Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 11580: Fix crashes while displaying large animated GIFs. Our old understanding of t... (Closed)

Created:
12 years, 1 month ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix crashes while displaying large animated GIFs. Our old understanding of the memory model here was wrong. This moves to the Cairo way of doing things. (An alternative would be to change NativeImagePtr from a raw pointer to a ref-counting pointer, like the Mac does. This would ape the Mac API, which is perhaps more future-proof, at the cost of needless refcounting complexity [since SkBitmap internally refs its pixel data already].) BUG=4298 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5860

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M webkit/port/platform/graphics/ImageSkia.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/port/platform/graphics/ImageSourceSkia.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M webkit/port/platform/image-decoders/ImageDecoder.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
12 years, 1 month ago (2008-11-21 21:10:51 UTC) #1
brettw
12 years, 1 month ago (2008-11-21 22:46:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698