Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: webkit/port/platform/graphics/ImageSkia.cpp

Issue 11580: Fix crashes while displaying large animated GIFs. Our old understanding of t... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/port/platform/graphics/ImageSourceSkia.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/port/platform/graphics/ImageSkia.cpp
===================================================================
--- webkit/port/platform/graphics/ImageSkia.cpp (revision 5830)
+++ webkit/port/platform/graphics/ImageSkia.cpp (working copy)
@@ -290,7 +290,9 @@
void FrameData::clear()
{
- // The frame data is released in ImageSource::clear.
+ // ImageSource::createFrameAtIndex() allocated |m_frame| and passed
+ // ownership to BitmapImage; we must delete it here.
+ delete m_frame;
m_frame = 0;
// NOTE: We purposefully don't reset metadata here, so that even if we
// throw away previously-decoded data, animation loops can still access
« no previous file with comments | « no previous file | webkit/port/platform/graphics/ImageSourceSkia.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698