Fix 2 bugs related to remembering loaded unpacked extensions.

Fix 2 bugs related to remembering loaded unpacked extensions.
- Extension disabled infobar was being shown at startup.
- Crashed extensions were persisted as unpacked extensions, regardless of how
they were installed.

BUG=30116
BUG=38856
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42394

[Aaron Boodman, 2010-03-23 16:18:26]

http://codereview.chromium.org/1157005/diff/3001/4001
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/1157005/diff/3001/4001#newcode2563
chrome/browser/browser.cc:2563: if
(service->extension_prefs()->DidExtensionEscalatePermissions(
Oh, cool that we already were storing this state.

I know it was already wrong, but as long as you're here, can you fix the names
in extension_prefs.cc around this? It was confusing when I was trying to track
down this code.

kShowInstallWarning => kExtensionDidEscalatePermissions
SetShowInstallWarningOnDisable => SetExtensionDidEscalatePermisssions

http://codereview.chromium.org/1157005/diff/3001/4002
File chrome/browser/extensions/extensions_service.cc (right):

http://codereview.chromium.org/1157005/diff/3001/4002#newcode254
chrome/browser/extensions/extensions_service.cc:254:
ExtensionPrefs::CollectExtensionsInfo(extension_prefs_.get()));
How about adding a GetInstallExtensionInfo() to ExtensionPrefs.

[Matt Perry, 2010-03-23 19:38:19]

http://codereview.chromium.org/1157005/diff/3001/4001
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/1157005/diff/3001/4001#newcode2563
chrome/browser/browser.cc:2563: if
(service->extension_prefs()->DidExtensionEscalatePermissions(
On 2010/03/23 16:18:26, Aaron Boodman wrote:
> Oh, cool that we already were storing this state.
> 
> I know it was already wrong, but as long as you're here, can you fix the names
> in extension_prefs.cc around this? It was confusing when I was trying to track
> down this code.
> 
> kShowInstallWarning => kExtensionDidEscalatePermissions
> SetShowInstallWarningOnDisable => SetExtensionDidEscalatePermisssions

Done.

http://codereview.chromium.org/1157005/diff/3001/4002
File chrome/browser/extensions/extensions_service.cc (right):

http://codereview.chromium.org/1157005/diff/3001/4002#newcode254
chrome/browser/extensions/extensions_service.cc:254:
ExtensionPrefs::CollectExtensionsInfo(extension_prefs_.get()));
On 2010/03/23 16:18:26, Aaron Boodman wrote:
> How about adding a GetInstallExtensionInfo() to ExtensionPrefs.

Done.

[Aaron Boodman, 2010-03-23 21:03:03]

lgtm