Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: chrome/browser/browser.cc

Issue 1157005: Fix 2 bugs related to remembering loaded unpacked extensions. (Closed)
Patch Set: review feedback 2 Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_disabled_infobar_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser.cc
diff --git a/chrome/browser/browser.cc b/chrome/browser/browser.cc
index 3b77d389a07aeb89cdc34c5704b686d43974a841..6afdb8c8f0cc9c9005a96ae782be734c0df60b74 100644
--- a/chrome/browser/browser.cc
+++ b/chrome/browser/browser.cc
@@ -2577,13 +2577,15 @@ void Browser::Observe(NotificationType type,
break;
case NotificationType::EXTENSION_UPDATE_DISABLED: {
- // Show the UI.
+ // Show the UI if the extension was disabled for escalated permissions.
Profile* profile = Source<Profile>(source).ptr();
DCHECK_EQ(profile_, profile);
ExtensionsService* service = profile->GetExtensionsService();
DCHECK(service);
Extension* extension = Details<Extension>(details).ptr();
- ShowExtensionDisabledUI(service, profile_, extension);
+ if (service->extension_prefs()->DidExtensionEscalatePermissions(
+ extension->id()))
+ ShowExtensionDisabledUI(service, profile_, extension);
break;
}
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_disabled_infobar_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698