Issue 115477: Fix unchecked pointer dereference that I stumbled across.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115477: Fix unchecked pointer dereference that I stumbled across. (Closed)

Created:
11 years, 7 months ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix unchecked pointer dereference that I stumbled across. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16312

Patch Set 1 #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/external_tab_container.cc	View		1 chunk	+3 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

amit

Thanks, for fixing this. http://codereview.chromium.org/115477/diff/1/2 File chrome/browser/external_tab_container.cc (right): http://codereview.chromium.org/115477/diff/1/2#newcode271 Line 271: LOG_IF(WARNING, load == NULL) ...

11 years, 7 months ago (2009-05-18 21:02:10 UTC) #2

robertshield

11 years, 7 months ago (2009-05-18 21:11:13 UTC) #3

http://codereview.chromium.org/115477/diff/1/2
File chrome/browser/external_tab_container.cc (right):

http://codereview.chromium.org/115477/diff/1/2#newcode271
Line 271: LOG_IF(WARNING, load == NULL) << "ExternalTabContainer received "
On 2009/05/18 21:02:10, amit wrote:
> I think this can be null for legitimate reasons, so no LOG is needed.

Done.

Expand Messages | Collapse Messages