Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/external_tab_container.cc

Issue 115477: Fix unchecked pointer dereference that I stumbled across. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/external_tab_container.cc
===================================================================
--- chrome/browser/external_tab_container.cc (revision 16185)
+++ chrome/browser/external_tab_container.cc (working copy)
@@ -268,7 +268,9 @@
case NotificationType::LOAD_STOP: {
const LoadNotificationDetails* load =
Details<LoadNotificationDetails>(details).ptr();
- if (PageTransition::IsMainFrame(load->origin())) {
+ LOG_IF(WARNING, load == NULL) << "ExternalTabContainer received "
amit 2009/05/18 21:02:10 I think this can be null for legitimate reasons, s
robertshield 2009/05/18 21:11:13 Done.
+ << "null LoadNotificationDetails in Observe(LOAD_STOP).";
+ if (load != NULL && PageTransition::IsMainFrame(load->origin())) {
automation_->Send(new AutomationMsg_TabLoaded(0, tab_handle_,
load->url()));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698