Issue 11547: Make sure to not mix allocators by using the correct StrDup function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11547: Make sure to not mix allocators by using the correct StrDup function. (Closed)

Created:
12 years, 1 month ago by iposva

Modified:
9 years, 3 months ago

Reviewers:
Feng Qian

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Make sure to not mix allocators by using the correct StrDup function. - Include needed system header. Committed: http://code.google.com/p/v8/source/detail?r=812

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/d8.cc	View		2 chunks	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Feng Qian

12 years, 1 month ago (2008-11-20 23:33:28 UTC) #2

LGTM, see comments.

http://codereview.chromium.org/11547/diff/1/2
File src/d8.cc (right):

http://codereview.chromium.org/11547/diff/1/2#newcode82
Line 82: return i::SmartPointer<char>(str ? i::StrDup(str) : str);
The fix looks good to me, but it does not resolve the confusion between
i::StrDup and i::OS::StrDup. Please file a  bug.

Expand Messages | Collapse Messages