src/d8.cc - Issue 11547: Make sure to not mix allocators by using the correct StrDup function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.cc

Issue 11547: Make sure to not mix allocators by using the correct StrDup function. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 12 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/d8.cc

===================================================================

--- src/d8.cc (revision 810)

+++ src/d8.cc (working copy)

@@ -26,6 +26,8 @@

// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+#include <stdlib.h>

#include "d8.h"

#include "debug.h"

#include "api.h"

@@ -77,7 +79,7 @@

char buffer[kBufferSize];

printf("%s", prompt);

char* str = fgets(buffer, kBufferSize, stdin);

- return i::SmartPointer<char>(str ? i::OS::StrDup(str) : str);

+ return i::SmartPointer<char>(str ? i::StrDup(str) : str);

Feng Qian 2008/11/20 23:33:28 The fix looks good to me, but it does not resolve

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »