Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 115461: Fixed StatusBubbleViews::AvoidMouse() to support the mirrored UI (RTL) mode.... (Closed)

Created:
11 years, 7 months ago by Yusuke (unused)
Modified:
9 years, 7 months ago
Reviewers:
Glen Murphy
CC:
chromium-reviews_googlegroups.com, jeremy, xji
Visibility:
Public.

Description

Fixed StatusBubbleViews::AvoidMouse() to support the mirrored UI (RTL) mode. BUG=12148 TEST=Start chromium with --lang=he. Hover a mouse cursor on a link in the bottom right corner, verify that the status bubble appears to the left. Verify that the status bubble appears in a normal (right) position for all other links.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/views/status_bubble_views.cc View 1 2 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke (unused)
Hi Glen, Could you review this as well? Thanks, Yusuke
11 years, 7 months ago (2009-05-18 09:54:29 UTC) #1
Glen Murphy
LGTM. Will submit shortly.
11 years, 7 months ago (2009-05-18 19:26:05 UTC) #2
Yusuke (unused)
Uploaded new patch set #3, since #2 conflicts with recent change (r16948). Thanks, Yusuke On ...
11 years, 7 months ago (2009-05-27 10:10:22 UTC) #3
Yusuke (unused)
Try succeeded.
11 years, 7 months ago (2009-05-27 14:41:49 UTC) #4
Glen Murphy
Sorry for taking so long to submit this and making you do update/try work as ...
11 years, 7 months ago (2009-05-27 21:38:59 UTC) #5
Yusuke (unused)
11 years, 7 months ago (2009-05-27 21:58:56 UTC) #6
Thanks, Glen!

Powered by Google App Engine
This is Rietveld 408576698