Issue 115378: Move Always On Top setting out of Window/WindowDelegate and into task manager...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115378: Move Always On Top setting out of Window/WindowDelegate and into task manager... (Closed)

Created:
11 years, 7 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Move Always On Top setting out of Window/WindowDelegate and into task manager. It's the only one who uses this setting and the UI for exposing it is very specific to the task manager. Window retains a setter to set always on top state, but persistence and the system menu is Task Manager's responsbility. This allows us to sever the second-to-last chrome dependency from views. http://crbug.com/11674 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16107

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+133 lines, -179 lines)			Patch
M	chrome/browser/task_manager_win.cc	View	7 chunks	+98 lines, -9 lines	2 comments	Download
M	chrome/browser/views/chrome_views_delegate.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/browser/views/chrome_views_delegate.cc	View	3 chunks	+1 line, -15 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/views/page_info_window.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/DEPS	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	views/views_delegate.h	View	2 chunks	+3 lines, -9 lines	0 comments	Download
M	views/window/window.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	views/window/window_delegate.h	View	2 chunks	+6 lines, -26 lines	0 comments	Download
M	views/window/window_delegate.cc	View	2 chunks	+2 lines, -13 lines	0 comments	Download
M	views/window/window_gtk.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	views/window/window_gtk.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	views/window/window_win.h	View	3 chunks	+1 line, -16 lines	0 comments	Download
M	views/window/window_win.cc	View	10 chunks	+9 lines, -75 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jcampan

11 years, 7 months ago (2009-05-14 21:15:09 UTC) #2

LGTM

http://codereview.chromium.org/115378/diff/3001/45
File chrome/browser/task_manager_win.cc (right):

http://codereview.chromium.org/115378/diff/3001/45#newcode223
Line 223: // Initialize the state of the always-on-top setting as the window is
shown.
Nit: Initializes

http://codereview.chromium.org/115378/diff/3001/45#newcode602
Line 602: return dictionary && dictionary->GetBoolean(L"always_on_top",
always_on_top) &&
Nit: is it more than 80 chars?

Expand Messages | Collapse Messages