Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: src/jump-target.h

Issue 115345: - Make VirtualFrame and JumpTarget zone allocated.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/virtual-frame-ia32.cc ('k') | src/jump-target.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/jump-target.h
===================================================================
--- src/jump-target.h (revision 1946)
+++ src/jump-target.h (working copy)
@@ -52,7 +52,7 @@
// In particular, this means that at least one of the control-flow
// graph edges reaching the target must be a forward edge.
-class JumpTarget : public Malloced { // Shadows are dynamically allocated.
+class JumpTarget : public ZoneObject { // Shadows are dynamically allocated.
public:
// Forward-only jump targets can only be reached by forward CFG edges.
enum Directionality { FORWARD_ONLY, BIDIRECTIONAL };
@@ -75,18 +75,9 @@
virtual void Initialize(CodeGenerator* cgen,
Directionality direction = FORWARD_ONLY);
- virtual ~JumpTarget() { Unuse(); }
-
- // Treat the jump target as a fresh one. The state is reset and
- // pointed-to virtual frames are deallocated. There should be no
- // dangling jumps to the target.
+ // Treat the jump target as a fresh one. The state is reset.
void Unuse();
- // Reset the internal state of this jump target. Pointed-to virtual
- // frames are not deallocated and dangling jumps to the target are
- // left dangling.
- void Reset();
-
// Accessors.
CodeGenerator* code_generator() const { return cgen_; }
@@ -175,11 +166,17 @@
// Directionality flag set at initialization time.
Directionality direction_;
+ // A target is bound if its Bind member function has been called.
+ // It is linked if it is not bound but its Jump, Branch, or Call
+ // member functions have been called.
+ bool is_bound_;
+ bool is_linked_;
+
// A list of frames reaching this block via forward jumps.
- List<VirtualFrame*> reaching_frames_;
+ ZoneList<VirtualFrame*> reaching_frames_;
// A parallel list of labels for merge code.
- List<Label> merge_labels_;
+ ZoneList<Label> merge_labels_;
// The frame used on entry to the block and expected at backward
// jumps to the block. Set when the jump target is bound, but may
@@ -189,12 +186,6 @@
// The actual entry label of the block.
Label entry_label_;
- // A target is bound if its Bind member function has been called.
- // It is linked if it is not bound but its Jump, Branch, or Call
- // member functions have been called.
- bool is_bound_;
- bool is_linked_;
-
// Implementations of Jump, Branch, and Bind with all arguments and
// return values using the virtual frame.
void DoJump();
@@ -296,10 +287,6 @@
// flow intended for the shadowed one.
explicit ShadowTarget(BreakTarget* shadowed);
- virtual ~ShadowTarget() {
- ASSERT(!is_shadowing_);
- }
-
// End shadowing. After shadowing ends, the original jump target
// again gives access to the formerly shadowed target and the shadow
// target object gives access to the formerly shadowing target.
« no previous file with comments | « src/ia32/virtual-frame-ia32.cc ('k') | src/jump-target.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698