Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Issue 1153006: When ChromeFrame is running in privileged mode, we should fail the IAuthentic... (Closed)

Created:
10 years, 9 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
stoyan
CC:
chromium-reviews, amit
Visibility:
Public.

Description

When ChromeFrame is running in privileged mode, we should fail the IAuthenticate::Authenticate method to prevent an authentication dialog from being displayed by IE. This CL passes this information to the Url request manager which in turn passes this to the requests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42275

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M chrome_frame/chrome_frame_activex.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome_frame/urlmon_url_request.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome_frame/urlmon_url_request.cc View 1 2 4 chunks +9 lines, -4 lines 0 comments Download
M chrome_frame/urlmon_url_request_private.h View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ananta
10 years, 9 months ago (2010-03-22 21:19:17 UTC) #1
stoyan
lgtm++ http://codereview.chromium.org/1153006/diff/1/3 File chrome_frame/urlmon_url_request.cc (right): http://codereview.chromium.org/1153006/diff/1/3#newcode550 chrome_frame/urlmon_url_request.cc:550: if (!parent_window || privileged_mode_) { if privileged_mode_ is ...
10 years, 9 months ago (2010-03-22 21:25:30 UTC) #2
ananta
10 years, 9 months ago (2010-03-22 21:42:24 UTC) #3
http://codereview.chromium.org/1153006/diff/1/3
File chrome_frame/urlmon_url_request.cc (right):

http://codereview.chromium.org/1153006/diff/1/3#newcode550
chrome_frame/urlmon_url_request.cc:550: if (!parent_window || privileged_mode_)
{
On 2010/03/22 21:25:30, stoyan wrote:
> if privileged_mode_ is true perhaps we want to return different error code
(not
> E_INVALIDARG)

Done.

Powered by Google App Engine
This is Rietveld 408576698