Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: chrome_frame/urlmon_url_request.cc

Issue 1153006: When ChromeFrame is running in privileged mode, we should fail the IAuthentic... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/urlmon_url_request.h ('k') | chrome_frame/urlmon_url_request_private.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/urlmon_url_request.cc
===================================================================
--- chrome_frame/urlmon_url_request.cc (revision 42240)
+++ chrome_frame/urlmon_url_request.cc (working copy)
@@ -39,7 +39,8 @@
: pending_read_size_(0),
headers_received_(false),
thread_(NULL),
- parent_window_(NULL) {
+ parent_window_(NULL),
+ privileged_mode_(false) {
DLOG(INFO) << StringPrintf("Created request. Obj: %X", this);
}
@@ -546,10 +547,12 @@
STDMETHODIMP UrlmonUrlRequest::Authenticate(HWND* parent_window,
LPWSTR* user_name,
LPWSTR* password) {
- if (!parent_window) {
+ if (!parent_window)
return E_INVALIDARG;
- }
+ if (privileged_mode_)
+ return E_FAIL;
+
DCHECK(::IsWindow(parent_window_));
*parent_window = parent_window_;
return S_OK;
@@ -897,6 +900,7 @@
request_info.upload_data,
enable_frame_busting_);
new_request->set_parent_window(notification_window_);
+ new_request->set_privileged_mode(privileged_mode_);
// Shall we use previously fetched data?
if (request_for_url.get()) {
@@ -1039,7 +1043,8 @@
UrlmonUrlRequestManager::UrlmonUrlRequestManager()
: stopping_(false), worker_thread_("UrlMon fetch thread"),
- map_empty_(true, true), notification_window_(NULL) {
+ map_empty_(true, true), notification_window_(NULL),
+ privileged_mode_(false) {
}
UrlmonUrlRequestManager::~UrlmonUrlRequestManager() {
« no previous file with comments | « chrome_frame/urlmon_url_request.h ('k') | chrome_frame/urlmon_url_request_private.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698