Issue 115149: Implement the popup blocking whitelist pref. This makes the whitelist actual...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115149: Implement the popup blocking whitelist pref. This makes the whitelist actual... (Closed)

Created:
11 years, 7 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Implement the popup blocking whitelist pref. This makes the whitelist actually function.BUG=11440 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15702

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -27 lines)			Patch
M	base/values.h	View	2 chunks	+3 lines, -4 lines	1 comment	Download
M	base/values.cc	View	3 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/browser_prefs.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/views/blocked_popup_container.h	View	5 chunks	+15 lines, -2 lines	0 comments	Download
M	chrome/browser/views/blocked_popup_container.cc	View	7 chunks	+36 lines, -7 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

11 years, 7 months ago (2009-05-09 00:20:41 UTC) #2

LGTM with the following changes.

http://codereview.chromium.org/115149/diff/1/3
File chrome/browser/views/blocked_popup_container.h (right):

http://codereview.chromium.org/115149/diff/1/3#newcode103
Line 103: virtual ~BlockedPopupContainer();
nit: style guide sayeth constructors/destructors before statics.

http://codereview.chromium.org/115149/diff/11/18
File base/values.h (right):

http://codereview.chromium.org/115149/diff/11/18#newcode337
Line 337: // Removes the first instance of |in_value| found in the list, if any.
I think this should take a const Value& as you aren't changing ownership like
the other methods.

Expand Messages | Collapse Messages