Implement the popup blocking whitelist pref. This makes the whitelist actual...

base/values.h

Index: base/values.h
===================================================================
--- base/values.h	(revision 15654)
+++ base/values.h	(working copy)
@@ -334,6 +334,9 @@
   // it will return false and the ListValue object will be unchanged.
   bool Remove(size_t index, Value** out_value);
 
+  // Removes the first instance of |in_value| found in the list, if any.

[sky, 2009/05/09 00:20:41]

I think this should take a const Value& as you aren't changing ownership like
the other methods.

+  void Remove(Value* in_value);
+
   // Appends a Value to the end of the list.
   void Append(Value* in_value);
 
@@ -347,10 +350,6 @@
   ListValue::const_iterator begin() const { return list_.begin(); }
   ListValue::const_iterator end() const { return list_.end(); }
 
-  ListValue::iterator Erase(iterator item) {
-    return list_.erase(item);
-  }
-
  private:
   DISALLOW_EVIL_CONSTRUCTORS(ListValue);