Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1147007: Adding test for checking to see if the devicekit-disks daemon is running (Closed)

Created:
10 years, 9 months ago by dhg
Modified:
9 years, 7 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org, kmixter1, petkov, seano, ericli, sosa
Visibility:
Public.

Description

Adding test for checking to see if the devicekit-disks daemon is running

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
A client/site_tests/platform_DiskIterate/control View 1 chunk +13 lines, -0 lines 0 comments Download
A client/site_tests/platform_DiskIterate/platform_DiskIterate.py View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dhg
10 years, 9 months ago (2010-03-22 21:28:52 UTC) #1
sosa
In this CL can you add dbus-python to hard-host-depends so that build_autotest.sh --build platform_DiskIterate is ...
10 years, 9 months ago (2010-03-22 22:13:49 UTC) #2
dhg
I hate to add something to the hard host depends which effects all the users ...
10 years, 9 months ago (2010-03-22 22:32:09 UTC) #3
sosa
I talked to Tedbo, and we should modify hard-host-depends for this information. Modifying hard-host-depends only ...
10 years, 9 months ago (2010-03-22 23:14:52 UTC) #4
dhg
roger! Will do! All sounds reasonable. On Mon, Mar 22, 2010 at 4:14 PM, <sosa@chromium.org> ...
10 years, 9 months ago (2010-03-22 23:15:54 UTC) #5
dhg
http://codereview.chromium.org/1110015 (since its in another git repo) On 2010/03/22 23:15:54, dhg wrote: > roger! Will ...
10 years, 9 months ago (2010-03-23 15:58:31 UTC) #6
sosa
You need to rev hard-host-depends (i.e. create a new symlink in that directory that points ...
10 years, 9 months ago (2010-03-23 16:39:42 UTC) #7
petkov
10 years, 9 months ago (2010-03-23 16:54:41 UTC) #8
On Tue, Mar 23, 2010 at 9:39 AM, <sosa@chromium.org> wrote:

> You need to rev hard-host-depends (i.e. create a new symlink in that
> directory
> that points to the ebuild) and then both of these are lgtm'd.
>

And delete old symlinks...


>
> Thanks for getting this in!
>
> http://codereview.chromium.org/1147007
>

Powered by Google App Engine
This is Rietveld 408576698