Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 11414046: Apply missing ReferencesParent check (Closed)

Created:
8 years, 1 month ago by Tom Sepez
Modified:
8 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Apply missing kParentDirectory check BUG=161564 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168692

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -30 lines) Patch
M content/browser/child_process_security_policy_impl.cc View 1 2 3 1 chunk +11 lines, -2 lines 0 comments Download
M content/browser/child_process_security_policy_unittest.cc View 1 2 3 1 chunk +70 lines, -28 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Tom Sepez
Adding @pima for OWNER.
8 years, 1 month ago (2012-11-17 02:15:30 UTC) #1
Tom Sepez
Actually, @darin is an owner and has context. Please review.
8 years, 1 month ago (2012-11-17 02:20:44 UTC) #2
piman
http://codereview.chromium.org/11414046/diff/7001/content/browser/child_process_security_policy_impl.cc File content/browser/child_process_security_policy_impl.cc (right): http://codereview.chromium.org/11414046/diff/7001/content/browser/child_process_security_policy_impl.cc#newcode148 content/browser/child_process_security_policy_impl.cc:148: return false; TBH, without more context, this seems overly ...
8 years, 1 month ago (2012-11-19 17:56:05 UTC) #3
Tom Sepez
@piman - you've been added to bug 161564.
8 years, 1 month ago (2012-11-19 18:02:18 UTC) #4
piman
Is this called only for renderers, or for, say, Pepper too? If only renderers, then ...
8 years, 1 month ago (2012-11-19 18:23:51 UTC) #5
Tom Sepez
On 2012/11/19 18:23:51, piman wrote: > Is this called only for renderers, or for, say, ...
8 years, 1 month ago (2012-11-19 19:24:57 UTC) #6
Tom Sepez
Revised Patch.
8 years, 1 month ago (2012-11-19 20:32:52 UTC) #7
piman
LGTM, and thanks for the test. Your right, I think the canonicalization step would be ...
8 years, 1 month ago (2012-11-19 20:57:57 UTC) #8
Tom Sepez
Per discussion, it sounds like we now want to go with the earlier patch set ...
8 years, 1 month ago (2012-11-19 22:15:01 UTC) #9
piman
On 2012/11/19 22:15:01, Tom Sepez wrote: > Per discussion, it sounds like we now want ...
8 years, 1 month ago (2012-11-19 22:33:53 UTC) #10
Tom Sepez
Ok. I'll land #4 and we can work on backtracking to #3. Need to get ...
8 years, 1 month ago (2012-11-19 22:40:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/11414046/8006
8 years, 1 month ago (2012-11-19 22:41:01 UTC) #12
commit-bot: I haz the power
Retried try job too often for step(s) interactive_ui_tests
8 years, 1 month ago (2012-11-19 23:57:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/11414046/8006
8 years, 1 month ago (2012-11-20 01:08:43 UTC) #14
commit-bot: I haz the power
8 years, 1 month ago (2012-11-20 01:54:00 UTC) #15
Change committed as 168692

Powered by Google App Engine
This is Rietveld 408576698