cc: Remove forbidden using namespace directives.

cc: Remove forbidden using namespace directives.

BUG=144576, 144577
TEST=cc_unittests
R=enne@chromium.org,jamesr@chromium.org,danakj@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167073

[jamesr, 2012-11-10 01:14:27]

lgtm

is anonymous-inside-actual namespace standard for tests in chromium?

[danakj, 2012-11-10 01:15:43]

http://codereview.chromium.org/11410022/diff/1/cc/active_animation_unittest.cc
File cc/active_animation_unittest.cc (right):

http://codereview.chromium.org/11410022/diff/1/cc/active_animation_unittest.c...
cc/active_animation_unittest.cc:16: namespace {
That looks like a script mistake? That's not how ui/gfx tests are..

[tfarina, 2012-11-10 01:18:45]

http://codereview.chromium.org/11410022/diff/1/cc/active_animation_unittest.cc
File cc/active_animation_unittest.cc (right):

http://codereview.chromium.org/11410022/diff/1/cc/active_animation_unittest.c...
cc/active_animation_unittest.cc:16: namespace {
On 2012/11/10 01:15:43, danakj wrote:
> That looks like a script mistake? That's not how ui/gfx tests are..
What is the problem? :)

Is perfectly fine to have them in unnamed namespace. And if you look elsewhere
not just ui/gfx/ you will notice that there are unittests only in unnamed
namespace, unittests in global namespace, unittests in specific namespaces, in
both as it's here, etc.

Leave it in the unnamed namespace + the cc namespace made possible to do less
changes.

And, no, I haven't used a script :/

[jamesr, 2012-11-10 01:20:12]

http://codereview.chromium.org/11410022/diff/1/cc/active_animation_unittest.cc
File cc/active_animation_unittest.cc (right):

http://codereview.chromium.org/11410022/diff/1/cc/active_animation_unittest.c...
cc/active_animation_unittest.cc:16: namespace {
On 2012/11/10 01:15:43, danakj wrote:
> That looks like a script mistake? That's not how ui/gfx tests are..

ui/gfx/point_unittest.cc seems similar, except for different newlines.
quad_unittest.cc isn't in an anonymous namespace, but you run the risk of ODR
violation rules in the unit test binary without the namespace

[commit-bot: I haz the power, 2012-11-10 01:20:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/11410022/1

[commit-bot: I haz the power, 2012-11-10 09:29:50]

Change committed as 167073