Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1141001: adds Devserver support for statically serving versioned updates. (Closed)

Created:
10 years, 9 months ago by seano
Modified:
9 years, 7 months ago
Reviewers:
kmixter1, rtc, ericli
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

adds Devserver support for statically serving versioned updates. Also decouples it from the chroot when run in serve-only mode.

Patch Set 1 #

Total comments: 4

Patch Set 2 : address ericli's comments #

Patch Set 3 : recommit as workaround for odd git merge behavior #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -61 lines) Patch
M src/platform/dev/autoupdate.py View 1 4 chunks +81 lines, -43 lines 0 comments Download
M src/platform/dev/buildutil.py View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/dev/devserver.py View 1 3 chunks +39 lines, -14 lines 0 comments Download
A src/platform/dev/update_test.py View 1 chunk +105 lines, -0 lines 0 comments Download
M src/scripts/start_devserver View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
seano
10 years, 9 months ago (2010-03-18 22:17:43 UTC) #1
ericli
The image on achieve server is inside image.zip, I didn't see how it is unzipped ...
10 years, 9 months ago (2010-03-19 04:55:26 UTC) #2
seano
I'm not committed to creating it at runtime yet. We might get update.gz with a ...
10 years, 9 months ago (2010-03-19 05:05:43 UTC) #3
ericli
http://codereview.chromium.org/1141001/diff/1/2 File src/platform/dev/autoupdate.py (right): http://codereview.chromium.org/1141001/diff/1/2#newcode75 src/platform/dev/autoupdate.py:75: image_file = '%s/rootfs.image' % image_path I guess I need ...
10 years, 9 months ago (2010-03-20 19:04:08 UTC) #4
seano
PTAL http://codereview.chromium.org/1141001/diff/1/2 File src/platform/dev/autoupdate.py (right): http://codereview.chromium.org/1141001/diff/1/2#newcode75 src/platform/dev/autoupdate.py:75: image_file = '%s/rootfs.image' % image_path On 2010/03/20 19:04:08, ...
10 years, 9 months ago (2010-03-21 00:45:06 UTC) #5
ericli
LGTM. You could deploy two devservers to the archive server (with different port) to server ...
10 years, 9 months ago (2010-03-21 01:34:32 UTC) #6
seano
10 years, 9 months ago (2010-03-21 01:41:00 UTC) #7
I'd prefer to just encode that in the update request somehow.

But for our initial use, we'll just run with -t, we only care about test
images.

pushing now.

On Sat, Mar 20, 2010 at 6:34 PM, <ericli@chromium.org> wrote:

> LGTM.
>
> You could deploy two devservers to the archive server (with different port)
> to
> server rootfs.image and rootfs_test.image respectively.
>
>
>
> On 2010/03/21 00:45:06, seano wrote:
>
>> PTAL
>>
>
>  http://codereview.chromium.org/1141001/diff/1/2
>> File src/platform/dev/autoupdate.py (right):
>>
>
>  http://codereview.chromium.org/1141001/diff/1/2#newcode75
>> src/platform/dev/autoupdate.py:75: image_file = '%s/rootfs.image' %
>> image_path
>> On 2010/03/20 19:04:08, ericli wrote:
>> > I guess I need rootfs_test.image on archieve server these days.
>> >
>> > Ideally lets make it configuration and default to rootfs.image.
>> >
>>
>
>  OK, devserver will look for rootfs_test.image (the output of  if started
>> with
>>
> -t
>
>  http://codereview.chromium.org/1141001/diff/1/4
>> File src/platform/dev/devserver.py (right):
>>
>
>  http://codereview.chromium.org/1141001/diff/1/4#newcode61
>> src/platform/dev/devserver.py:61: print 'using archive dir: %s' %
>> static_dir
>> On 2010/03/20 19:04:08, ericli wrote:
>> > line 61 and 65, use the same style to output message.
>> > web.debug() wins?
>>
>
>  Done.
>>
>
>
>
> http://codereview.chromium.org/1141001
>

Powered by Google App Engine
This is Rietveld 408576698