Handle mimetype queries for media files...

Handle mimetype queries for media files
Added code path from WebKit to net::mimt_util to query
supported mime-types for media files.

BUG=12777
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17225

[scherkus (not reviewing), 2009-05-29 16:05:52]

Before I jump into the code... now that we're "launched" make sure to add a
TEST= field to the description:

TEST=Visiting a text/plain page should not display media controls

[scherkus (not reviewing), 2009-05-29 16:11:02]

LGTM from a code point of view, should wait for darin for an architectural LGTM
:)

http://codereview.chromium.org/114060/diff/1007/1015
File net/base/mime_util.cc (right):

http://codereview.chromium.org/114060/diff/1007/1015#newcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
bump copyright year

http://codereview.chromium.org/114060/diff/1007/1014
File net/base/mime_util.h (right):

http://codereview.chromium.org/114060/diff/1007/1014#newcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
bump copyright year

http://codereview.chromium.org/114060/diff/1007/1012
File webkit/api/src/WebMediaPlayerClientImpl.cpp (right):

http://codereview.chromium.org/114060/diff/1007/1012#newcode339
Line 339: return MediaPlayer::IsSupported;
webkit style: indent extra two spaces

[darin (slow to review), 2009-05-29 16:38:30]

Looks good except:

http://codereview.chromium.org/114060/diff/1007/1012
File webkit/api/src/WebMediaPlayerClientImpl.cpp (right):

http://codereview.chromium.org/114060/diff/1007/1012#newcode338
Line 338: if (ChromiumBridge::isSupportedMediaMIMEType(type))
Since this is WebKit API code, you do not need to use ChromiumBridge to call
this method.

You can just call webKitClient()->mimeRegistry()->supportsMediaMIMEType(type)
directly.

Not having to change WebCore seems like a good thing to me.

[Alpha Left Google, 2009-05-29 19:04:32]

Address the style issues, remove changes from ChromiumBridge and added supported
mimetypes.

[scherkus (not reviewing), 2009-05-29 19:32:11]

LGTM with one comment nit

http://codereview.chromium.org/114060/diff/3011/3017
File net/base/mime_util.cc (right):

http://codereview.chromium.org/114060/diff/3011/3017#newcode173
Line 173: "audio/ogg",        // Ogg and Theora.
this is really nitty, but technically these comments aren't accurate (mime types
specify the container not the codec)

also it's a little hard to read.. what about having the comments go before the
"chunks"