Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: webkit/api/src/WebMediaPlayerClientImpl.cpp

Issue 114060: Handle mimetype queries for media files... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/api/public/WebMimeRegistry.h ('k') | webkit/glue/simple_webmimeregistry_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/api/src/WebMediaPlayerClientImpl.cpp
===================================================================
--- webkit/api/src/WebMediaPlayerClientImpl.cpp (revision 17048)
+++ webkit/api/src/WebMediaPlayerClientImpl.cpp (working copy)
@@ -13,6 +13,7 @@
#include "WebKit.h"
#include "WebKitClient.h"
#include "WebMediaPlayer.h"
+#include "WebMimeRegistry.h"
#include "WebRect.h"
#include "WebSize.h"
#include "WebString.h"
@@ -326,16 +327,17 @@
void WebMediaPlayerClientImpl::getSupportedTypes(HashSet<String>& supportedTypes)
{
- // FIXME: decide what to do here, we should fill in the HashSet about
- // codecs that we support.
+ // FIXME: integrate this list with WebMediaPlayerClientImpl::supportsType.
notImplemented();
}
MediaPlayer::SupportsType WebMediaPlayerClientImpl::supportsType(const String& type,
const String& codecs)
{
- // FIXME: implement this properly.
- return MediaPlayer::IsSupported;
+ // FIXME: respect codecs, now we only check for mime-type.
+ if (webKitClient()->mimeRegistry()->supportsMediaMIMEType(type))
+ return MediaPlayer::IsSupported;
+ return MediaPlayer::IsNotSupported;
}
WebMediaPlayerClientImpl::WebMediaPlayerClientImpl()
« no previous file with comments | « webkit/api/public/WebMimeRegistry.h ('k') | webkit/glue/simple_webmimeregistry_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698