Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 114059: Refactors HWNDView, NativeViewHostGtk and NativeViewHost so that they match t... (Closed)

Created:
11 years, 6 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
brettw, sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Refactors HWNDView, NativeViewHostGtk and NativeViewHost so that they match the NativeControl pattern established for NativeButtons. NativeViewHost is a platform-neutral class that clients instantiate. Behind the scenes the platform instantiates the appropriate NativeViewHostWrapper implementation, either NativeViewHostGtk (as before) or NativeViewHostWin (replaces HWNDView). BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17169

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 1

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+467 lines, -990 lines) Patch
M chrome/browser/extensions/extension_view.h View 1 2 3 4 5 6 3 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_view.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/about_ipc_dialog.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/about_ipc_dialog.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/constrained_window_impl.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/constrained_window_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/dom_view.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
chrome/browser/views/dom_view.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/location_bar_view.h View 1 2 3 4 5 6 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/views/location_bar_view.cc View 1 2 3 4 5 6 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/views/tab_contents/native_tab_contents_container_gtk.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/tab_contents/native_tab_contents_container_win.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/tab_contents/native_tab_contents_container_win.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/temp_scaffolding_stubs.h View 1 2 3 4 5 6 1 chunk +0 lines, -24 lines 0 comments Download
M views/controls/button/native_button_gtk.cc View 1 2 3 4 5 6 3 chunks +3 lines, -2 lines 0 comments Download
M views/controls/button/native_button_win.cc View 1 2 3 4 5 6 5 chunks +7 lines, -7 lines 0 comments Download
D views/controls/hwnd_view.h View 1 2 3 4 5 6 1 chunk +0 lines, -66 lines 0 comments Download
D views/controls/hwnd_view.cc View 1 2 3 4 5 6 1 chunk +0 lines, -138 lines 0 comments Download
A + views/controls/native/native_view_host.h View 2 chunks +48 lines, -45 lines 0 comments Download
A + views/controls/native/native_view_host.cc View 1 2 3 4 5 6 4 chunks +75 lines, -17 lines 0 comments Download
A + views/controls/native/native_view_host_gtk.h View 1 2 3 2 chunks +22 lines, -24 lines 0 comments Download
A + views/controls/native/native_view_host_gtk.cc View 1 2 3 3 chunks +77 lines, -61 lines 0 comments Download
views/controls/native/native_view_host_win.h View 1 chunk +23 lines, -43 lines 0 comments Download
A + views/controls/native/native_view_host_win.cc View 1 2 1 chunk +71 lines, -74 lines 0 comments Download
A views/controls/native/native_view_host_wrapper.h View 1 chunk +62 lines, -0 lines 0 comments Download
M views/controls/native_control.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
views/controls/native_control.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M views/controls/native_control_gtk.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M views/controls/native_control_gtk.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/native_control_win.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M views/controls/native_control_win.cc View 1 2 3 4 5 6 4 chunks +16 lines, -16 lines 0 comments Download
D views/controls/native_view_host.h View 1 2 3 4 5 6 1 chunk +0 lines, -101 lines 0 comments Download
D views/controls/native_view_host.cc View 1 2 3 4 5 6 1 chunk +0 lines, -79 lines 0 comments Download
D views/controls/native_view_host_gtk.h View 1 2 3 4 5 6 1 chunk +0 lines, -62 lines 0 comments Download
D views/controls/native_view_host_gtk.cc View 1 2 3 4 5 6 1 chunk +0 lines, -157 lines 0 comments Download
M views/controls/scrollbar/native_scroll_bar.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/scrollbar/native_scroll_bar.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/separator.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M views/controls/table/table_view.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M views/controls/textfield/native_textfield_win.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/textfield/native_textfield_win.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M views/controls/textfield/textfield.cc View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
views/focus/focus_manager.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M views/view_unittest.cc View 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M views/views.gyp View 1 2 3 4 5 6 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
11 years, 6 months ago (2009-05-29 02:23:22 UTC) #1
brettw
11 years, 6 months ago (2009-05-29 05:08:49 UTC) #2
This is a very nice change. LGTM

http://codereview.chromium.org/114059/diff/2167/2170
File views/controls/native/native_view_host.cc (right):

http://codereview.chromium.org/114059/diff/2167/2170#newcode99
Line 99: // The area behind our window is black, so during a fast resize (where
our
This comment is confusing. It refers to HWND several times but this is in shared
code. The last part also seems to imply web pages, which is also not always
true.

Powered by Google App Engine
This is Rietveld 408576698