chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc - Issue 114059: Refactors HWNDView, NativeViewHostGtk and NativeViewHost so that they match t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc

Issue 114059: Refactors HWNDView, NativeViewHostGtk and NativeViewHost so that they match t... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/views/tab_contents/native_tab_contents_container_gtk.h ('k') | chrome/browser/views/tab_contents/native_tab_contents_container_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc

===================================================================

--- chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc (revision 17161)

+++ chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc (working copy)

@@ -30,7 +30,7 @@

// We need to register the tab contents window with the BrowserContainer so

// that the BrowserContainer is the focused view when the focus is on the

// TabContents window (for the TabContents case).

- SetAssociatedFocusView(this);

+ set_focus_view(this);

Attach(contents->GetNativeView());

@@ -45,7 +45,7 @@

void NativeTabContentsContainerGtk::DetachContents(TabContents* contents) {

// TODO(port): figure out focus interception

#if defined(OS_WIN)

- // TODO(brettw) should this move to HWNDView::Detach which is called below?

+ // TODO(brettw) should this move to NativeViewHost::Detach which is called below?

// It needs cleanup regardless.

HWND container_hwnd = contents->GetNativeView();