We need to save bookmarks file when the persist_ids settings changes...

chrome/browser/bookmarks/bookmark_model.h

Index: chrome/browser/bookmarks/bookmark_model.h
===================================================================
--- chrome/browser/bookmarks/bookmark_model.h	(revision 17017)
+++ chrome/browser/bookmarks/bookmark_model.h	(working copy)
@@ -328,6 +328,9 @@
   bool PersistIDs() const { return persist_ids_; }
   void SetPersistIDs(bool value);
 
+  // Returns whether the bookmarks file changed externally.
+  bool file_changed() const { return file_changed_; }
+
  private:
   // Used to order BookmarkNodes by URL.
   class NodeURLComparator {
@@ -418,6 +421,9 @@
   // persisted.
   void set_next_node_id(int id) { next_node_id_ = id; }
 
+  // Records that the bookmarks file was changed externally.
+  void SetFileChanged();
+
   // Creates and returns a new LoadDetails. It's up to the caller to delete
   // the returned object.
   BookmarkStorage::LoadDetails* CreateLoadDetails();
@@ -437,6 +443,9 @@
   // Whether to persist bookmark IDs.
   bool persist_ids_;
 
+  // Whether the bookmarks file was changed manulaly by the user.
+  bool file_changed_;

[sky, 2009/05/28 19:13:17]

manulaly -> manually
Can you also add this is set after loading is completed and once set the value
is never changed.

[Munjal (Google), 2009/05/28 19:17:52]

Done. I used "externally" instead of "manually" as that's what I use in other
places.

+
   // The root node. This contains the bookmark bar node and the 'other' node as
   // children.
   BookmarkNode root_;