We need to save bookmarks file when the persist_ids settings changes...

chrome/browser/bookmarks/bookmark_model.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_MODEL_H_
 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_MODEL_H_
 
 #include "build/build_config.h"
 
 #include <set>
@@ skipping 310 matching lines @@
 
   // Sets the store to NULL, making it so the BookmarkModel does not persist
   // any changes to disk. This is only useful during testing to speed up
   // testing.
   void ClearStore();
 
   // Sets/returns whether or not bookmark IDs are persisted or not.
   bool PersistIDs() const { return persist_ids_; }
   void SetPersistIDs(bool value);
 
+  // Returns whether the bookmarks file changed externally.
+  bool file_changed() const { return file_changed_; }
+
  private:
   // Used to order BookmarkNodes by URL.
   class NodeURLComparator {
    public:
     bool operator()(BookmarkNode* n1, BookmarkNode* n2) const {
       return n1->GetURL() < n2->GetURL();
     }
   };
 
   // Implementation of IsBookmarked. Before calling this the caller must
@@ skipping 70 matching lines @@
 
   // Generates and returns the next node ID.
   int generate_next_node_id();
 
   // Sets the maximum node ID to the given value.
   // This is used by BookmarkCodec to report the maximum ID after it's done
   // decoding since during decoding codec can assign IDs to nodes if IDs are
   // persisted.
   void set_next_node_id(int id) { next_node_id_ = id; }
 
+  // Records that the bookmarks file was changed externally.
+  void SetFileChanged();
+
   // Creates and returns a new LoadDetails. It's up to the caller to delete
   // the returned object.
   BookmarkStorage::LoadDetails* CreateLoadDetails();
 
   // Registers bookmarks related prefs.
   void RegisterPreferences();
   // Loads bookmark related preferences.
   void LoadPreferences();
 
   NotificationRegistrar registrar_;
 
   Profile* profile_;
 
   // Whether the initial set of data has been loaded.
   bool loaded_;
 
   // Whether to persist bookmark IDs.
   bool persist_ids_;
 
+  // Whether the bookmarks file was changed manulaly by the user.
+  bool file_changed_;

[sky, 2009/05/28 19:13:17]

manulaly -> manually
Can you also add this is set after loading is completed and once set the value
is never changed.

[Munjal (Google), 2009/05/28 19:17:52]

Done. I used "externally" instead of "manually" as that's what I use in other
places.

+
   // The root node. This contains the bookmark bar node and the 'other' node as
   // children.
   BookmarkNode root_;
 
   BookmarkNode* bookmark_bar_node_;
   BookmarkNode* other_node_;
 
   // The maximum ID assigned to the bookmark nodes in the model.
   int next_node_id_;
 
@@ skipping 15 matching lines @@
   scoped_refptr<BookmarkStorage> store_;
 
   scoped_ptr<BookmarkIndex> index_;
 
   base::WaitableEvent loaded_signal_;
 
   DISALLOW_COPY_AND_ASSIGN(BookmarkModel);
 };
 
 #endif  // CHROME_BROWSER_BOOKMARKS_BOOKMARK_MODEL_H_