Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 114054: Splits TooltipManager so that it can be ported and stubs out the GTK... (Closed)

Created:
11 years, 7 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Splits TooltipManager so that it can be ported and stubs out the GTK side. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17076

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -662 lines) Patch
M chrome/browser/views/tabs/tab.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M views/views.gyp View 1 1 chunk +4 lines, -1 line 0 comments Download
M views/widget/aero_tooltip_manager.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M views/widget/aero_tooltip_manager.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M views/widget/tooltip_manager.h View 1 2 chunks +12 lines, -129 lines 0 comments Download
D views/widget/tooltip_manager.cc View 1 1 chunk +0 lines, -448 lines 0 comments Download
A views/widget/tooltip_manager_gtk.h View 1 chunk +37 lines, -0 lines 0 comments Download
A views/widget/tooltip_manager_gtk.cc View 1 chunk +51 lines, -0 lines 0 comments Download
A + views/widget/tooltip_manager_win.h View 1 5 chunks +22 lines, -32 lines 0 comments Download
A + views/widget/tooltip_manager_win.cc View 15 chunks +39 lines, -33 lines 0 comments Download
M views/widget/widget_gtk.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M views/widget/widget_gtk.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M views/widget/widget_win.h View 1 3 chunks +11 lines, -3 lines 0 comments Download
M views/widget/widget_win.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
11 years, 7 months ago (2009-05-27 22:48:28 UTC) #1
brettw
Fancy. LGTM. http://codereview.chromium.org/114054/diff/1/2 File views/widget/tooltip_manager_gtk.h (right): http://codereview.chromium.org/114054/diff/1/2#newcode37 Line 37: #endif // VIEWS_WIDGET_TOOLTIP_MANAGER_GTK_H_ Need 2 spaces ...
11 years, 7 months ago (2009-05-27 22:55:03 UTC) #2
sky
11 years, 7 months ago (2009-05-28 16:02:00 UTC) #3
This uncovered a subtle long existing bug in the destruction order during
WM_SESSIONEND of WidgetWin. I've fixed it along with this.

Powered by Google App Engine
This is Rietveld 408576698