Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: views/widget/widget_win.h

Issue 114054: Splits TooltipManager so that it can be ported and stubs out the GTK... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/widget/widget_gtk.cc ('k') | views/widget/widget_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/widget/widget_win.h
===================================================================
--- views/widget/widget_win.h (revision 17063)
+++ views/widget/widget_win.h (working copy)
@@ -24,7 +24,7 @@
namespace views {
class RootView;
-class TooltipManager;
+class TooltipManagerWin;
class DefaultThemeProvider;
class Window;
@@ -506,7 +506,17 @@
// Returns true if this WidgetWin is opaque.
bool opaque() const { return opaque_; }
+ // The TooltipManager.
+ // WARNING: RootView's destructor calls into the TooltipManager. As such, this
+ // must be destroyed AFTER root_view_. This really only matters during
+ // WM_SESSIONEND, as normally the hwnd is destroyed which tiggers unsetting
+ // the widget in the RootView so that RootView's destructor doesn't call into
+ // the TooltipManager.
+ scoped_ptr<TooltipManagerWin> tooltip_manager_;
+
// The root of the View hierarchy attached to this window.
+ // WARNING: see warning in tooltip_manager_ for ordering dependencies with
+ // this and tooltip_manager_.
scoped_ptr<RootView> root_view_;
// Whether or not we have capture the mouse.
@@ -515,8 +525,6 @@
// If true, the mouse is currently down.
bool is_mouse_down_;
- scoped_ptr<TooltipManager> tooltip_manager_;
-
// Are a subclass of WindowWin?
bool is_window_;
« no previous file with comments | « views/widget/widget_gtk.cc ('k') | views/widget/widget_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698