Issue 114033: Fix a crash in the extension system when sending response back

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 114033: Fix a crash in the extension system when sending response back (Closed)

Created:
11 years, 7 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Jói Sigurðsson, Aaron Boodman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a crash in the extension system when sending response back to extension with no results. Also found an UMR causing DCHECKs to hit repeatedly (in AsyncExtensionFunction::SetArgs). BUG=None TEST=Basically, use any extension that calls an API function that returns no results (such as PageAction) and Chrome should not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16325

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	chrome/browser/extensions/extension_function.h	View	2	3 chunks	+3 lines, -2 lines	0 comments	Download
	M	chrome/browser/extensions/extension_function.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Finnur

Also found an UMR causing DCHECKs. Updated. On 2009/05/18 19:22:39, Aaron Boodman wrote: > LGTM

11 years, 7 months ago (2009-05-18 19:32:17 UTC) #4

LGTM

Doh! Sorry guys, and thanks Finnur!

Expand Messages | Collapse Messages